AArch64: temporary fix for trig and log functions in jdk11u

Andrew Dinn adinn at redhat.com
Tue Sep 25 15:48:55 UTC 2018


On 25/09/18 14:41, Rob McKenna wrote:
> Would you mind generating a webrev and posting to cr.openjdk.java.net or
> attaching the patches to email? (or the bug!) Thanks,
No problem. diffs wrt the latest jdk11u are included below. The first
diff indicates patch needed to stop the sin_cos intrinsic being
published. The second diff inhibits publication of the log intrinsic.

regards,


Andrew Dinn
-----------
Senior Principal Software Engineer
Red Hat UK Ltd
Registered in England and Wales under Company Registration No. 03798903
Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander

---- 8< ------- 8< ------- 8< ------- 8< ------- 8< ------- 8< ---
diff -r 1ddf9a99e4ad src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp

--- a/src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp»       Wed Aug
22 21:50:12 2018 +0200

+++ b/src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp»       Thu Sep
13 13:51:53 2018 +0100

@@ -5745,11 +5745,13 @@

     }



     if (vmIntrinsics::is_intrinsic_available(vmIntrinsics::_dsin)) {

-      StubRoutines::_dsin = generate_dsin_dcos(/* isCos = */ false);

+      // disabled pending fix and retest of generated code

+      // StubRoutines::_dsin = generate_dsin_dcos(/* isCos = */ false);

     }



     if (vmIntrinsics::is_intrinsic_available(vmIntrinsics::_dcos)) {

-      StubRoutines::_dcos = generate_dsin_dcos(/* isCos = */ true);

+      // disabled pending fix and retest of generated code

+      // StubRoutines::_dcos = generate_dsin_dcos(/* isCos = */ true);

     }

   }
---- 8< ------- 8< ------- 8< ------- 8< ------- 8< ------- 8< ---
diff --git a/src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp
b/src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp

--- a/src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp

+++ b/src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp

@@ -5741,7 +5741,8 @@

     }



     if (vmIntrinsics::is_intrinsic_available(vmIntrinsics::_dlog)) {

-      StubRoutines::_dlog = generate_dlog();

+      // disabled pending fix and retest of generated code

+      // StubRoutines::_dlog = generate_dlog();

     }



     if (vmIntrinsics::is_intrinsic_available(vmIntrinsics::_dsin)) {
---- 8< ------- 8< ------- 8< ------- 8< ------- 8< ------- 8< ---



More information about the jdk-updates-dev mailing list