[11u] RFR, RFA, discussion: JDK-8210633, JDK-8205432 (Japanese Era changes)

Langer, Christoph christoph.langer at sap.com
Wed Apr 3 13:10:28 UTC 2019


Hi,

looking at JBS, we can see that for JDK 11.0.3 the two changes for JDK-8210633, JDK-8205432 regarding the Japanese era need to be included.

Since the jdk11u repository is frozen now, Andrew Hughes will add them to the CPU repository and merge them to jdk11u on April the 16th. However, there's probably some interest in the patches for the community to build with.

JDK-8210633 applies cleanly from its original commit [0]. @Andrew Haley<mailto:aph at redhat.com>: I've requested both, jdk11u and jdk11u-critical approval for this change. Please do the needful.

JDK-8205432 had to be resolved against jdk11u. I've prepared a webrev for it [1]. I hereby request a review of this backport patch. I had to do the following modifications:

make/data/cldr/common/main/ja.xml -> applied against src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ja.xml (file has moved)
make/data/cldr/common/main/root.xml -> applied against src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/root.xml (file has moved)
test/jdk/java/time/test/java/time/format/TestNonIsoFormatter.java -> copyright hunk failed, ignore
test/jdk/java/util/Calendar/CalendarTestScripts/CalendarAdapter.java -> doesn't apply because test don't exist in jdk11
test/jdk/java/util/Calendar/CalendarTestScripts/Symbol.java -> doesn't apply because test don't exist in jdk11
test/jdk/java/util/Calendar/CalendarTestScripts/japanese/japanese.cts -> doesn't apply because test don't exist in jdk11
test/jdk/java/util/Calendar/CalendarTestScripts/japanese/japanese_add.cts -> doesn't apply because test don't exist in jdk11
test/jdk/java/util/Calendar/CalendarTestScripts/japanese/japanese_minmax.cts -> doesn't apply because test don't exist in jdk11
test/jdk/java/util/Calendar/CalendarTestScripts/japanese/japanese_roll.cts -> doesn't apply because test don't exist in jdk11
test/jdk/java/util/Calendar/JapaneseEraNameTest.java -> resolved, the update for China locale did not apply since China is not tested in jdk11u
test/jdk/java/util/Calendar/JapaneseLenientEraTest.java -> copyright hunk failed, ignore


@Andrew Hughes<mailto:gnu.andrew at redhat.com>: Shall I push both patches to jdk11u-dev once they are reviewed and approved? You could probably cherry-pick them from jdk11u-dev to the CPU repository then. Or did you already do some work for JDK-8205432 in the CPU which you want to be transported the other way? Just let me know the next steps.

Best regards
Christoph

[0] http://hg.openjdk.java.net/jdk/jdk/rev/a0426bc28519
[1] http://cr.openjdk.java.net/~clanger/webrevs/8205432.jdk11u-dev.0/



More information about the jdk-updates-dev mailing list