[11u] RFR, RFA, discussion: JDK-8210633, JDK-8205432 (Japanese Era changes)

[Langer, Christoph]

Hi Andrew

> > @Andrew Hughes <mailto:gnu.andrew at redhat.com>: Shall I push both
> patches
> > to jdk11u-dev once they are reviewed and approved? You could probably
> > cherry-pick them from jdk11u-dev to the CPU repository then. Or did you
> > already do some work for JDK-8205432 in the CPU which you want to be
> > transported the other way? Just let me know the next steps.
> >
> >
> >
> > Best regards
> >
> > Christoph
> >
> >
> >
> > [0] http://hg.openjdk.java.net/jdk/jdk/rev/a0426bc28519
> >
> > [1] http://cr.openjdk.java.net/~clanger/webrevs/8205432.jdk11u-dev.0/
> >
> >
> >
> 
> As I said here:
> 
> https://mail.openjdk.java.net/pipermail/jdk-updates-dev/2019-
> April/000864.html
> 
> I'm working on this. In fact, I already have this in our local versions
> of 11.0.3+7 and 8u212-b03. I'm just waiting on approvals of
> https://bugs.openjdk.java.net/browse/JDK-8219890 and
> https://bugs.openjdk.java.net/browse/JDK-8208656 before posting.
> 
> Please don't duplicate work others are doing.

Well, I knew this but I didn't know how exactly you were planning to do it. So it was a good exercise to familiarize with the topic ��

Now I see, you're planning to also take the prerequisites JDK-8219890 and JDK-8208656. Looks like a good idea to me and probably completely saves the need for adapting the patch for JDK-8205432. ��

As for the process, then I think you should add jdk11u-critical-request to the bugs JDK-8219890 and JDK-8208656, since you'll take them into 11.0.3 via the CPU. And I guess a Fix Request comment mentioning that these bugs are prerequisite to JDK-8205432 would be nice, too.

Looking forward to seeing pushes of JDK-8205432, JDK-8219890, JDK-8208656 and JDK-8205432 in jdk11u-dev then.

Thanks,
Christoph