[11u] RFR: 8163511: Allocation of compile task fails with assert: "Leaking compilation tasks?"

[Aleksey Shipilev]

On 8/5/19 4:37 PM, Roman Kennke wrote:
> It required a change in compileTask.cpp, because the _failure_reason
> handling is not in 11. The changes in tieredThresholdPolicy.cpp needed
> to be done on simpleThresholdPolicy.cpp instead.
> 
> Original bug:
> https://bugs.openjdk.java.net/browse/JDK-8163511
> 
> Original fix:
> http://hg.openjdk.java.net/jdk/jdk/rev/cd701366fcf8
> 
> 11-backport webrev:
> http://cr.openjdk.java.net/~rkennke/8163511/webrev11.00/

From the brief look, seems okay.

Three things to consider:

 a) Please run the new regression test without the product changes: does it fail?

 b) There is JDK-8209186 (rename to tieredThresholdPolicy.cpp) backport that is approved, but not
yet not pushed to jdk11u-dev. That should simplify the backports like these: it should not require
adjustments then. My fault it was not pushed until now. Please rebase your patch?

 c) The issue has the dependent one, JDK-8220341, which should also be brought in (as separate
backport) right after this change lands. Please make sure both are reviewed. Push them at the same time.

-- 
Thanks,
-Aleksey