[11u] RFR: 8222299: [TESTBUG] move hotspot container tests to hotspot/containers

[Severin Gehwolf]

Hi Christoph,

On Tue, 2019-08-06 at 09:25 +0000, Langer, Christoph wrote:
> Hi,
>  
> please review the backport of 8222299: [TESTBUG] move hotspot
> container tests to hotspot/containers. This is something that Oracle
> has brought back to 11.0.5.
>  
> Bug: https://bugs.openjdk.java.net/browse/JDK-8222299
> Webrev: 
> http://cr.openjdk.java.net/~clanger/webrevs/8222299.11u-dev.0/
>  
> There needed to be some adaptions to the original fix. Firstly,
> changes to the following files really don’t apply to 11u so these
> were skipped:
> /doc/testing.html
> /doc/testing.md
> test/hotspot/jtreg/ProblemList.txt

OK. Though the comments wrt. container testing will apply verbatim once
my backports are in.

> Then, the set of files needing to be moved from
> test/hotspot/jtreg/runtime/containers to
> test/hotspot/jtreg/containers is different in current jdk11u-dev
> compared to the original change. So I manually moved everything from
> the former location to the latter.

OK. Could I ask you to wait with this patch until my other JDK 11 test
changes are in? Otherwise this would require me to do reviews, instead
of a simple approval.

> And eventually I tried to make the change in
> test/lib/jdk/test/lib/containers/docker/DockerTestUtils.java fit to
> the current state of the code in there.

 164         try {
 165             // Build the docker
 166             execute("docker", "build", "--no-cache", "--tag", imageName, buildDir.toString())
 167                 .shouldHaveExitValue(0);
 168         } catch (Exception e) {
 169             // If docker image building fails there is a good chance it happens due to environment and/or
 170             // configuration other than product failure. Throw jtreg skipped exception in such case
 171             // instead of failing the test.
 172             throw new SkippedException("Building docker image failed. Details: \n" + e.getMessage());
 173         }

It looks like you are referencing SkippedException without the import
statement. Does this actually compile?

> @Severin: don’t know if there’s some interference with your docker
> test work…

It does. Would it be acceptable if I'd let you know once this can be
pushed?

Thanks,
Severin