[11u] RFR: 8222299: [TESTBUG] move hotspot container tests to hotspot/containers

Langer, Christoph christoph.langer at sap.com
Thu Aug 8 13:49:57 UTC 2019


Hi Severin,

sure, the backport of JDK-8222299 will look much different now after all the container fixes you are bringing in.

Just let me know when it's time for JDK-8222299, e.g. after all required predecessor patches in the container area are pushed.

Best regards
Christoph

> -----Original Message-----
> From: Severin Gehwolf <sgehwolf at redhat.com>
> Sent: Donnerstag, 8. August 2019 15:34
> To: Langer, Christoph <christoph.langer at sap.com>; jdk-updates-
> dev at openjdk.java.net
> Subject: Re: [11u] RFR: 8222299: [TESTBUG] move hotspot container tests to
> hotspot/containers
> 
> Christoph,
> 
> On Thu, 2019-08-08 at 13:20 +0200, Severin Gehwolf wrote:
> > > And eventually I tried to make the change in
> > > test/lib/jdk/test/lib/containers/docker/DockerTestUtils.java fit to
> > > the current state of the code in there.
> >
> >  164         try {
> >  165             // Build the docker
> >  166             execute("docker", "build", "--no-cache", "--tag", imageName,
> buildDir.toString())
> >  167                 .shouldHaveExitValue(0);
> >  168         } catch (Exception e) {
> >  169             // If docker image building fails there is a good chance it happens
> due to environment and/or
> >  170             // configuration other than product failure. Throw jtreg skipped
> exception in such case
> >  171             // instead of failing the test.
> >  172             throw new SkippedException("Building docker image failed.
> Details: \n" + e.getMessage());
> >  173         }
> >
> > It looks like you are referencing SkippedException without the import
> > statement. Does this actually compile?
> 
> I've just noticed that JDK-8221710 adds SkippedException, which I'm
> planning to backport (before this goes in). So feel free to disregard
> this comment.
> 
> Thanks,
> Severin



More information about the jdk-updates-dev mailing list