[11u] RFR: 8220672: [TESTBUG] TestCPUSets should check that cpuset does not exceed available cores

Severin Gehwolf sgehwolf at redhat.com
Thu Aug 8 16:17:31 UTC 2019


Hi Christoph,

On Wed, 2019-07-31 at 13:18 +0000, Langer, Christoph wrote:
> Hi Severin,
> 
> this looks good.

Thanks for the review!

> I think we really want to have the SkippedException in 11u ��

Since SkippedException is now in, I've updated the webrev. Changes from
head were:

JDK 11 path of the test is different:

test/hotspot/jtreg/containers/docker/TestCPUSets.java =>
test/hotspot/jtreg/runtime/containers/docker/TestCPUSets.java

Still no ProblemList.txt entry for this test => Omitted.

No other changes.

http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8220672/jdk11/02/webrev/

If you prefer I can wait with this backport until after your move
change, which would get rid of one more adaptation.

Thoughts?

Thanks,
Severin

> Best regards
> Christoph
> 
> > -----Original Message-----
> > From: jdk-updates-dev <jdk-updates-dev-bounces at openjdk.java.net> On
> > Behalf Of Severin Gehwolf
> > Sent: Montag, 22. Juli 2019 03:58
> > To: jdk-updates-dev at openjdk.java.net
> > Subject: [11u] RFR: 8220672: [TESTBUG] TestCPUSets should check
> > that
> > cpuset does not exceed available cores
> > 
> > Hi,
> > 
> > I'm working on getting better container testing experience in JDK
> > 11u.
> > One of the issues I'd like to backport is this one. Also, it's one
> > of
> > those cases which got backported in 11.0.5-oracle.
> > 
> > The jdk/jdk changeset didn't apply cleanly since a)
> > jtreg.SkippedException is being thrown in jdk/jdk, not available in
> > JDK
> > 11u b) TestCPUSets.java wasn't problem-listed in JDK 11u. Otherwise
> > the
> > patch is the same.
> > 
> > I've not included the change for b) and opted for
> > System.out.println()
> > and return as a substitute for a).
> > 
> > Bug: https://bugs.openjdk.java.net/browse/JDK-8220672
> > webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-
> > 8220672/jdk11/01/webrev/
> > original-changeset: 
> > http://hg.openjdk.java.net/jdk/jdk/rev/a73fe240da4a
> > 
> > Testing: Ran docker tests on Linux x86_64.
> > 
> > Thoughts?
> > 
> > Thanks,
> > Severin



More information about the jdk-updates-dev mailing list