[11u]: RFR JDK-8227368: EnumSet.class serialization broken in JDK 9+

[Peter Levart]

Hi Stuart,

On 8/8/19 6:16 PM, Stuart Marks wrote:
> Hi, yes, I saw that Andrew Haley had approved this at the beginning of 
> last week. Of course we were at JVMLS+OCW so no actual work got done 
> on it. More recently I've been catching up and I've also been trying 
> to test the change before pushing it. Unfortunately I've been in a bit 
> of a wrestling match with our internal build/test system, since it's 
> not set up to jdk11u-dev (it's only set up for the Oracle 11u family).
>
> Is there a CI system for jdk11u-dev? Would that be shipilev's setup?
>
> Re CSR, I guess I should have pushed the fix last week before the CSR 
> was instituted for 11-updates. j/k :-)
>
> Actually I did talk to Joe Darcy and we agreed that this would be a 
> good test run for the CSR for updates, not only because the mainline 
> fix had a CSR, but because the "backport" differs significantly from 
> the mainline fix.
>
> Relatedly, the backport CSR will be completely different from the CSR 
> for the mainline fix. A different set of compatibility considerations 
> is in play, specifically, no specification changes.
>
> I was assuming that I'd work on this, but if somebody (Peter) wants to 
> pick it up that'd be ok too.

Perhaps it would be best if you continue with it, since you have access 
to various facilities needed for this patch (JCK tests for example) and 
are more acquainted with the JSR process.

Thanks,

Peter

>
> s'marks
>
> On 8/8/19 8:14 AM, Langer, Christoph wrote:
>> Hi Peter,
>>
>> the fix has gotten jdk11u approval.
>>
>> However, it's an item that involves a CSR. So, before you can push to 
>> jdk11u, you'll need to open a JDK 11 specific CSR and have it 
>> reviewed. The contents should be copy&paste from the original CSR.
>>
>> I suggest you link the CSR to both, the 11-pool and the 11.0.6-oracle 
>> backport item.
>>
>> Thanks
>> Christoph
>>
>>> -----Original Message-----
>>> From: jdk-updates-dev <jdk-updates-dev-bounces at openjdk.java.net> On
>>> Behalf Of Peter Levart
>>> Sent: Donnerstag, 8. August 2019 13:24
>>> To: Stuart Marks <stuart.marks at oracle.com>
>>> Cc: jdk-updates-dev at openjdk.java.net
>>> Subject: Re: [11u]: RFR JDK-8227368: EnumSet.class serialization 
>>> broken in
>>> JDK 9+
>>>
>>> Hi Stuart,
>>>
>>> I see the JDK-8227368 has got an approval label (jdk11u-fix-yes). 
>>> Should
>>> the change you have prepared for this backport [1] be pushed to
>>> jdk-updates/jdk11u-dev now?
>>>
>>> Regards, Peter
>>>
>>> On 7/18/19 1:11 AM, Stuart Marks wrote:
>>>>
>>>>
>>>> On 7/17/19 3:48 PM, Stuart Marks wrote:
>>>>> I've set the fix-version of the backport record JDK-8227650 to 11.0.5
>>>>> ...
>>>>
>>>> I changed this to 11-pool on advice from Joe Darcy, as this will make
>>>> it more likely that that the automatic hg-updater will pick up this
>>>> backport issue when the fix gets pushed to some 11-update release.
>>>>
>>>> s'marks
>>