[11u] RFR 8216401: Allow "file:" URLs in Class-Path of local JARs

[Zhengyu Gu]

Hi,

After JDK-8222914, now original patch applies cleanly.

Thanks,

-Zhengyu

On 7/31/19 10:52 PM, Langer, Christoph wrote:
> Hi Zhengyu,
> 
> thanks for looking into this backport. It is obviously on Oracle's list - however, not for JDK11. Nevertheless, I guess it could be backported.
> 
> As for the code change: Looks good overall. As for the usage of JarUtils: With my backport for JDK-8205654 and another one that I'm about to do for JDK- 8222914, I'm bringing some parts of updates to JarUtils in jdk/jdk. Maybe you want to wait for these and see if you can then use jdk.test.lib.util.JarUtils as it is done in jdk/jdk.
> 
> Thanks
> Christoph
> 
>> -----Original Message-----
>> From: jdk-updates-dev <jdk-updates-dev-bounces at openjdk.java.net> On
>> Behalf Of Zhengyu Gu
>> Sent: Mittwoch, 31. Juli 2019 13:32
>> To: jdk-updates-dev at openjdk.java.net
>> Subject: [11u] RFR 8216401: Allow "file:" URLs in Class-Path of local JARs
>>
>> I would like to backport this patch to 11u, as it appears to be on
>> Oracle's backport list.
>>
>> The patch does not apply cleanly. The fix itself applies cleanly, but
>> included test does not, apparently due to test infrastructure changes.
>>
>>
>> Original Bug: https://bugs.openjdk.java.net/browse/JDK-8216401
>> Original Webrev:
>> https://mail.openjdk.java.net/pipermail/core-libs-dev/2019-
>> January/057868.html
>> Original review thread:
>> https://mail.openjdk.java.net/pipermail/core-libs-dev/2019-
>> January/057868.html
>>
>>
>> 11u webrev: http://cr.openjdk.java.net/~zgu/JDK-8216401-11u/webrev.00/
>>
>> Test:
>>     Passed included test.
>>
>> Diff:
>> diff -r 8967c5ef0b65
>> test/jdk/jdk/internal/loader/URLClassPath/JarClassPathFileEntry.java
>> ---
>> a/test/jdk/jdk/internal/loader/URLClassPath/JarClassPathFileEntry.java
>> Mon Jan 14 11:22:32 2019 -0800
>> +++
>> b/test/jdk/jdk/internal/loader/URLClassPath/JarClassPathFileEntry.java
>> Wed Jul 31 16:15:11 2019 -0400
>> @@ -28,14 +28,14 @@
>>    import java.nio.file.Paths;
>>    import java.util.jar.Attributes;
>>    import java.util.jar.Manifest;
>> -import jdk.test.lib.util.JarUtils;
>>    import jdk.test.lib.compiler.InMemoryJavaCompiler;
>>
>>    /*
>>     * @test
>>     * @bug 8216401
>>     * @summary Test loading of JAR Class-Path entry with file: scheme
>> - * @library /test/lib
>> + * @library /lib/testlibrary /test/lib
>> + * @build JarClassPathFileEntry JarUtils jdk.testlibrary.*
>>     *
>>     * @run main/othervm JarClassPathFileEntry
>>     * @run main/othervm
>> -Djdk.net.URLClassPath.disableClassPathURLCheck=true
>> JarClassPathFileEntry
>>
>> Thanks,
>>
>> -Zhengyu