[11u] RFR: 8222299: [TESTBUG] move hotspot container tests to hotspot/containers

Severin Gehwolf sgehwolf at redhat.com
Mon Aug 19 14:38:27 UTC 2019


Hi Aleksey,

Thanks for the review!

Change of plans. I think it makes more sense to get JDK-8219997 and
JDK-8221894 backported too. Why? Risk is low, test-only/doc changes and
the documentation is actually acurate for JDK 11u as well for jdk-
11.0.5+3 onwards. More below.

On Mon, 2019-08-19 at 15:32 +0200, Aleksey Shipilev wrote:
> On 8/19/19 2:20 PM, Severin Gehwolf wrote:
> > (haven't looked at backporting JDK-8219997),
> 
> Um. I don't understand this. JDK-8219997:
>  http://hg.openjdk.java.net/jdk/jdk/rev/dcaced4cbb83
> 
> Do you mean JDK-8219997 would possibly go after this backport is done, which would require
> additional shuffling to fit the new location?

Yes, that would have been the case. On second thought, though, it seems
easier to get all 3 patches in. They seem easy enough. Latest webrev is
then the same as for JDK 13 modulo ProblemList.txt changes.

> > webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8222299/jdk11/02/webrev/
> > Bug: https://bugs.openjdk.java.net/browse/JDK-8222299
> > original changeset: http://hg.openjdk.java.net/jdk/jdk/rev/5ae4d3f46537
> 
> No test/hotspot/jtreg/ProblemList.txt changes required either?
>   http://hg.openjdk.java.net/jdk/jdk/rev/5ae4d3f46537#l3.1

Yes. TestCPUSets.java has never been problem-listed in JDK 11. JDK-
8220672 fixes the reason why it was problem listed which is pending
maintainer approval at this point and will be a pre-requisite for this
backport.

Latest webrev which now matches JDK 13 with *only* the ProblemList.txt
omission:
http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8222299/jdk11/03/webrev/

Thoughts?

Thanks,
Severin



More information about the jdk-updates-dev mailing list