[11u] RFR: 8221894: Add comments for docker tests in the test doc

Severin Gehwolf sgehwolf at redhat.com
Tue Aug 20 10:16:30 UTC 2019


Hi Aleksey,

Thanks for the review!

On Tue, 2019-08-20 at 12:07 +0200, Aleksey Shipilev wrote:
> On 8/19/19 4:55 PM, Severin Gehwolf wrote:
> > Please review this doc-only OpenJDK 11u backport so as to get a more
> > clean backport of JDK-8222299. See discussion in [1]. The JDK 13 patch
> > does not apply cleanly since testing.html looks different. However,
> > that's a generated file (via "make update-build-docs") and
> > doc/testing.md applies cleanly. So the proposed webrev is applying
> > doc/testing.md changes as-is from JDK 13 and then use the generated
> > doc/testing.html changes after running "make update-build-docs".
> 
> That makes sense.
> 
> > Bug: https://bugs.openjdk.java.net/browse/JDK-8221894
> > webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8221894/jdk11/01/webrev/
> > Original changeset: http://hg.openjdk.java.net/jdk/jdk/rev/e437ad5643d6
> 
> I think this hunk is irrelevant and might be caused by different version on pandoc on any given machine?
> 
> @@ -11,7 +11,7 @@
>        span.underline{text-decoration: underline;}
>        div.column{display: inline-block; vertical-align: top; width: 50%;}
>    </style>
> -  <link rel="stylesheet" href="../make/data/docs-resources/resources/jdk-default.css">
> +  <link rel="stylesheet" href="../make/data/docs-resources/resources/jdk-default.css" />
>    <!--[if lt IE 9]>
>      <script src="//cdnjs.cloudflare.com/ajax/libs/html5shiv/3.7.3/html5shiv-printshiv.min.js"></script>
>    <![endif]-->
> 
> Maybe we should drop it to make the patch only doing Docker-related changes.

Sure, done:
http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8221894/jdk11/02/webrev/

Thanks,
Severin



More information about the jdk-updates-dev mailing list