[11u] RFR 8225715: jhsdb jmap fails to write binary heap dump of a jshell process

[Severin Gehwolf]

Hi Aleksey,

On Fri, 2019-08-16 at 19:29 +0200, Aleksey Shipilev wrote:
> Original bug:
>   https://bugs.openjdk.java.net/browse/JDK-8225715
>   https://hg.openjdk.java.net/jdk/jdk/rev/f60890de1dfb
> 
> The patch does not apply cleanly to 11u, because we miss quite large JDK-8205534 that changed the
> context by adding "names" HashSet. Fortunately, the patch can be re-applied by hand in an obvious
> manner. The test is not affected.
> 
> 11u webrev:
>   https://cr.openjdk.java.net/~shade/8225715/webrev.11u.01/
> 
> Testing: new test (fails without product fix, passes with it); tier1

src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/utilities/HeapHprofBinWriter.java
-------------------------------------------------------------------------------------

writeSymbol():

JDK 11 doesn't track symbols which have already been written, thus the
surrounding conditional "if (names.add(sym))" is not present in the
backport patch. OK.

writeSymbolID():

No assert in the backport patch because "names" HashSet not being
present. OK.

test/jdk/sun/tools/jhsdb/JShellHeapDumpTest.java
------------------------------------------------

Same as for jdk/jdk. OK.


Looks good to me. Thumbs up.

I'd suggest to run test/jdk/sun/tools/jhsdb tests before you push.

Thanks,
Severin