[11u] RFR(S): 8221408: Windows 32bit build build errors/warnings in hotspot

[Thomas Stüfe]

Hi Goetz,

looks good.

I'm a bit worried about JDK-8221725 though. That was caused by 8221408
making the anonymous enum at ln 130 in markOop.hpp smaller. Then, compiler
decided on aarch to make the size of the whole enum smaller. Since
markOopDesc::lock_mask_in_place got smaller and it was used as a bit mask
where size matters that led to 8221725.

Of course you need to downport 8221725 too, but that is not my point. What
I think is you maybe could, in addition, add two bogus enum values at the
end of the anonymous enum (and bogus use them somewhere), to replace the
ones I made static variables. That way the enum has guaranteed the same
size and no compiler would decide to make the enum smaller.

Maybe I'm too paranoid...

Cheers, Thomas




On Tue, Aug 6, 2019 at 5:19 PM Lindenmaier, Goetz <goetz.lindenmaier at sap.com>
wrote:

> Hi,
>
> I would like to downport this change as it fixes warnings
> of the windows 32 bit build.
> I had to change the syntax of the pragma disabling
> the warning in os_windows_x86.cpp, because the macros
> used in jdk13 are not available in jdk11.  Thus I need a review.
>
> We are using visual studio 17, Version 19.16.27031.1.
> http://cr.openjdk.java.net/~goetz/wr19/8221408-ntintel_warnings-jdk11/01/
>
> Best regards,
>   Goetz.
>
>