[11u] RFR 8224589: Improve startup behavior of SecurityProperties

[Langer, Christoph]

Hi guys,

I'm back from vacation and getting catched up with 11u things ��

As for this one, can we do this: http://cr.openjdk.java.net/~clanger/webrevs/8224589.11u-dev.0/ ?

I've firstly applied the relevant parts of JDK-8207768 (http://hg.openjdk.java.net/jdk/jdk/rev/6ffa38b8da65) , that is, the changes to src/java.base/share/classes/sun/net/util/SocketExceptions.java and  src/java.base/share/classes/sun/security/util/SecurityProperties.java. After that, I applied JDK-8224589 which went in cleanly. I qfolded both patches.

I will place it into our jdk11u queue and when everything is green, I'd like to push it to 11u (11.0.5). It is part of Oracles's 11.0.5 and fixes a performance regression - so we should take it.

Martins patch for JDK-8215032 can eventually take advantage of it when it was merged back to 11u-dev.

What do you tink?

Thanks
Christoph


> -----Original Message-----
> From: jdk-updates-dev <jdk-updates-dev-bounces at openjdk.java.net> On
> Behalf Of Aleksey Shipilev
> Sent: Dienstag, 27. August 2019 19:53
> To: Martin Balao <mbalao at redhat.com>; jdk-updates-
> dev at openjdk.java.net
> Subject: Re: [11u] RFR 8224589: Improve startup behavior of
> SecurityProperties
> 
> On 8/27/19 4:45 PM, Aleksey Shipilev wrote:
> > On 8/27/19 4:28 PM, Martin Balao wrote:
> >> Please note that some bits of 8224589 were backported to jdk11u in
> >> 8215032 [1]. In particular, "privilegedGetOverridable" and
> >> "getOverridableProperty" functions were placed in
> >> SecurityProperties.java [2]. I suggest to take those bits from the
> >> 8215032 backport, so these common functions can be shared between
> >> different classes.
> >
> > Right. We can do just that: pick up SecurityProperties.java and just call into
> it? I have no opinion
> > either way...
> >
> > Like this:
> >   https://cr.openjdk.java.net/~shade/8224589/webrev.11u.02/
> 
> Passes tier1, tier2 on Linux x86_64. Unfortunately, it is past the 11.0.5
> rampdown, and I am leaning
> not to rush it, and instead take it to the early 11.0.6.
> 
> --
> Thanks,
> -Aleksey