RFR [XS] : 8235478: [jdk11] handle VS2017 15.9 and VS2019 in vm_version.cpp

[Baesken, Matthias]

Hi Christoph, thanks .

> , please request backport approval in JDK-
> 8235243 and JDK-8235325.


I   added  the     jdk11u-fix-request     label  to both bugs  .

Best regards, Matthias



> Hi Matthias,
> 
> the change itself looks good.
> 
> However, your approach to create a new bug which is actually a backport of
> two other bugs is not the right thing to do. I converted JDK-8235478 to be a
> backport of JDK-8235243. Now, please request backport approval in JDK-
> 8235243 and JDK-8235325. Once it's approved, please push your change with
> a commit message that resolves both items, that is:
> 
> 8235243: handle VS2017 15.9 and VS2019 in abstract_vm_version
> 8235325: build failure on Linux after 8235243
> Reviewed-by: dholmes, mdoerr
> 
> This will pick up and resolve JDK-8235478 as backport of 8235243 and
> create/resolve another backport item for 8235325.
> 
> Best regards
> Christoph
> 
> 
> > -----Original Message-----
> > From: hotspot-dev <hotspot-dev-bounces at openjdk.java.net> On Behalf
> Of
> > Baesken, Matthias
> > Sent: Montag, 9. Dezember 2019 12:37
> > To: jdk-updates-dev at openjdk.java.net
> > Cc: 'hotspot-dev at openjdk.java.net' <hotspot-dev at openjdk.java.net>
> > Subject: RFR [XS] : 8235478: [jdk11] handle VS2017 15.9 and VS2019 in
> > vm_version.cpp
> >
> > Hello, please review this small  jdk11 change .
> > It handles  VS2017 15.9 and VS2019 in vm_version.cpp .
> >
> > More or less it is a jdk11 - downport of  what 8235243 + 8235325  do , but in
> > jdk/jdk  .
> >
> > Bug/webrev :
> >
> > https://bugs.openjdk.java.net/browse/JDK-8235478
> >
> > http://cr.openjdk.java.net/~mbaesken/webrevs/8235478.0/
> >
> >
> > Thanks, Matthias