[11u] RFR: 8235585: Enable macOS codesigning for all libraries and executables

Baesken, Matthias matthias.baesken at sap.com
Tue Dec 17 12:14:19 UTC 2019


Hi Rene, the backport looks good to me .


I am not sure about the   MACOSX_PRIVILEGED   settings ,   there might be more j-tools  needing it.
Here 

http://cr.openjdk.java.net/~rschuenemann/wr/2019/8235585-macOS_Signing-jdk11/01/make/launcher/Launcher-jdk.jcmd.gmk.frames.html

I see  the setting   MACOSX_PRIVILEGED     added   for jinfo,  jmap,  jstack .

Have you checked jcmd itself ( I have no Catalina  at hand so cannot check it myself, maybe it is fine as is )  ?

Best regards, Matthias


> 
> Message: 1
> Date: Mon, 16 Dec 2019 15:50:48 +0100
> From: Ren? Sch?nemann <rene.schuenemann at gmail.com>
> To: jdk-updates-dev at openjdk.java.net
> Subject: [11u] RFR: 8235585: Enable macOS codesigning for all
> 	libraries and executables
> Message-ID:
> 	<CAL26=jPoTUSFyhXfVt6jQt6rd5Nsko3yfnNvaXSg_kG0Ffz1Ag at mail.
> gmail.com>
> Content-Type: text/plain; charset="UTF-8"
> 
> Hi,
> 
> can I please get a review for this 11u backport, code signing all
> libraries and executables on macOS?
> 
> I had to resolve "make/launcher/LauncherCommon.gmk".
> 
> https://bugs.openjdk.java.net/browse/JDK-8235585
> http://cr.openjdk.java.net/~rschuenemann/wr/2019/8235585-
> macOS_Signing-jdk11/01/
> http://hg.openjdk.java.net/jdk/jdk/rev/dcf88e5c8c07
> 
> Best Regards
> Rene
> 
> 



More information about the jdk-updates-dev mailing list