[11u] RFR: 8235687: Contents/MacOS/libjli.dylib cannot be a symlink

René Schünemann rene.schuenemann at gmail.com
Wed Dec 18 11:16:06 UTC 2019


Hi Goetz,

thank you for the review.

Rene

On Tue, Dec 17, 2019 at 12:38 PM Lindenmaier, Goetz
<goetz.lindenmaier at sap.com> wrote:
>
> Hi Rene,
>
> the only difference I spotted is that 11 calls $(MKDIR) and
> 14 calls MakeTargetDir in the deleted code.
> This is encapsulated in SetupCopyFiles which is called
> by the new code.
>
> Looks good.
>
> Best regards,
>   Goetz.
>
> > -----Original Message-----
> > From: jdk-updates-dev <jdk-updates-dev-bounces at openjdk.java.net> On
> > Behalf Of René Schünemann
> > Sent: Dienstag, 17. Dezember 2019 10:24
> > To: jdk-updates-dev at openjdk.java.net
> > Subject: [11u] RFR: 8235687: Contents/MacOS/libjli.dylib cannot be a symlink
> >
> > Hi,
> >
> > can I please get a review for this 11u backport?
> > This change is needed for Apple notarization on macOS.
> >
> > I had to resolve "make/MacBundles.gmk" since the libjli.dylib" path in
> > 11u differs from jdk/jdk.
> >
> > https://bugs.openjdk.java.net/browse/JDK-8235687
> > http://cr.openjdk.java.net/~rschuenemann/wr/2019/8235687-
> > macOS_libjli_symlink-jdk11/01/
> > https://hg.openjdk.java.net/jdk/jdk14/rev/7a1e6bd6a836
> >
> > Best Regards
> > Rene


More information about the jdk-updates-dev mailing list