[11u] RFR: 8232806: Introduce a system property to disable eager lambda initialization

Jie Kang jkang at redhat.com
Thu Dec 19 17:39:00 UTC 2019


On Thu, Dec 19, 2019 at 8:48 AM Langer, Christoph <christoph.langer at sap.com>
wrote:

> Hi Jie,
>
> backport looks good, thanks for doing this.
>
> As for the CSR: It would not have been necessary as Oracle did that
> already for 11-pool: https://bugs.openjdk.java.net/browse/JDK-8233134.
> However, I also saw that your new CSR got approved (for their backport
> https://bugs.openjdk.java.net/browse/JDK-8233133)... So, now it's double
> safe ��
>

Hey Christoph

Thanks for reviewing this. I have submitted the fix-request label and
comment on the original bug:
https://bugs.openjdk.java.net/browse/JDK-8232806


Regards,


> Cheers
> Christoph
>
>
> > -----Original Message-----
> > From: jdk-updates-dev <jdk-updates-dev-bounces at openjdk.java.net> On
> > Behalf Of Jie Kang
> > Sent: Mittwoch, 18. Dezember 2019 14:50
> > To: jdk-updates-dev <jdk-updates-dev at openjdk.java.net>
> > Subject: [11u] RFR: 8232806: Introduce a system property to disable eager
> > lambda initialization
> >
> > Hi,
> >
> > Please review this backport for JDK-8232806. This is useful for
> > graalvm and has also already been backported into 11.0.7-oracle, so
> > should be included at least for parity.
> >
> > Backport Webrev
> > http://cr.openjdk.java.net/~jkang/JDK-8232806/webrev.1/
> >
> > Original Commit
> > https://hg.openjdk.java.net/jdk/jdk/rev/27c2d2a4b695
> > Original Bug
> > https://bugs.openjdk.java.net/browse/JDK-8232806
> >
> > The patch did not function cleanly due to missing
> > GetBooleanAction.privilegedGetProperty in 11u. The call to this has
> > been replaced by the lengthier form used elsewhere and also prior to
> > the introduction of above static helper method:
> >
> > disableEagerInitialization = AccessController.doPrivileged(
> >     new GetBooleanAction(disableEagerInitializationKey)).booleanValue();
> >
> > Let me know what you think about this adjustment. The tier one tests
> > including the modified LambdaTest6 passed for me.
> >
> >
> > Regards,
>
>


More information about the jdk-updates-dev mailing list