[11u] [JFR] RFR 8209850: Allow NamedThreads to use GlobalCounter critical sections

[Jaroslav Bachorík]

Hi Christoph,

thanks! Are you going to do the separate RFR for 8209976? Not completely
clear so better asking.

Cheers,

-JB-

On Fri, Dec 20, 2019 at 4:09 PM Langer, Christoph <christoph.langer at sap.com>
wrote:

> Hi Jaroslav,
>
>
>
> Ok, change is tested, approved and pushed now. ��
>
>
>
> I’ll take on JDK-8209976 then. Will run it through tests and have an
> updated version reviewed in a separate thread.
>
>
>
> Best regards
>
> Christoph
>
>
>
> *From:* Jaroslav Bachorík <jaroslav.bachorik at datadoghq.com>
> *Sent:* Donnerstag, 19. Dezember 2019 13:43
> *To:* Langer, Christoph <christoph.langer at sap.com>
> *Cc:* jdk-updates-dev <jdk-updates-dev at openjdk.java.net>; Hohensee, Paul <
> hohensee at amazon.com>
> *Subject:* Re: [11u] [JFR] RFR 8209850: Allow NamedThreads to use
> GlobalCounter critical sections
>
>
>
> Hi Christoph,
>
>
>
> I can confirm that your proposed patch is identical to the
> original backport patch and the only change is in
> test_singleWriterSynchronizer.cpp: #include "threadHelper.inline.hpp" ->
> #include "utilitiesHelper.inline.hpp"
>
>
>
> LGTM
>
>
>
> -JB-
>
>
>
> On Thu, Dec 19, 2019 at 1:08 PM Langer, Christoph <
> christoph.langer at sap.com> wrote:
>
> Hi Jaroslav,
>
> I just ran the patch through our test system and found that it wouldn't
> build.
>
> I had to change one include in test_singleWriterSynchronizer.cpp: #include
> "threadHelper.inline.hpp" -> #include "utilitiesHelper.inline.hpp". I think
> you have that change in your webrev for JDK- 8209976 which comes next in
> your queue.
>
> So, I think the correct backport of JDK-8209850 would look like this:
> http://cr.openjdk.java.net/~clanger/webrevs/8209850.11u/
>
> Can I please get a review for this? I'd approve & push after I have a
> review and build results on Windows. The Linux/Unix world looks good so far.
>
> Thanks
> Christoph
>
>
> > -----Original Message-----
> > From: jdk-updates-dev <jdk-updates-dev-bounces at openjdk.java.net> On
> > Behalf Of Hohensee, Paul
> > Sent: Donnerstag, 12. Dezember 2019 17:10
> > To: Jaroslav Bachorík <jaroslav.bachorik at datadoghq.com>; jdk-updates-dev
> > <jdk-updates-dev at openjdk.java.net>
> > Subject: Re: [11u] [JFR] RFR 8209850: Allow NamedThreads to use
> > GlobalCounter critical sections
> >
> > Lgtm.
> >
> > Paul
> >
> > On 12/12/19, 7:41 AM, "jdk-updates-dev on behalf of Jaroslav Bachorík"
> > <jdk-updates-dev-bounces at openjdk.java.net on behalf of
> > jaroslav.bachorik at datadoghq.com> wrote:
> >
> >      Hi all,
> >
> >     please, review this backport which is a prerequisite for the planned
> >     backport of JDK-8225797
> >
> >     JIRA .   : https://bugs.openjdk.java.net/browse/JDK-8209850
> >     Webrev : http://cr.openjdk.java.net/~jbachorik/8209850/webrev.00/
> >
> >     The patch applies with fuzz and the patch diff is listed at
> >     http://cr.openjdk.java.net/~jbachorik/8209850/webrev.00/patch.diff
> >
> >     Thanks,
> >
> >     -JB-
> >
>
>