[11u] RFR: 8217634: RunTest documentation and usability update

Lindenmaier, Goetz goetz.lindenmaier at sap.com
Mon Dec 30 10:24:37 UTC 2019


Hi Christoph, 

thanks for reviewing!

Best regards,
  Goetz.

> -----Original Message-----
> From: Langer, Christoph <christoph.langer at sap.com>
> Sent: Montag, 30. Dezember 2019 11:07
> To: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>; jdk-updates-
> dev at openjdk.java.net
> Subject: RE: [11u] RFR: 8217634: RunTest documentation and usability update
> 
> Hi Goetz,
> 
> I skimmed over your change and the rejects and it looks correct to me. I also
> agree about not backporting the parts about JCOV since it's not in available in
> 11.
> 
> Best regards
> Christoph
> 
> > -----Original Message-----
> > From: jdk-updates-dev <jdk-updates-dev-bounces at openjdk.java.net> On
> > Behalf Of Lindenmaier, Goetz
> > Sent: Dienstag, 24. Dezember 2019 10:43
> > To: jdk-updates-dev at openjdk.java.net
> > Subject: [CAUTION] [11u] RFR: 8217634: RunTest documentation and
> > usability update
> >
> > Hi,
> >
> > I had to do a lot of resolves for this one. It passed
> > Our build and testing.
> >
> > This change has a lot of syntactic corrections, like
> > adding line breaks. Many of these are in code not in 11.
> > I skipped them.
> >
> > The change adds documentation for JCOV. This is not
> > supported by 11 (and I can't see "8215729: Enhance makefiles
> > to allow collecting code coverage with JCov"
> > https://bugs.openjdk.java.net/browse/JDK-8215729 was downported),
> > so I removed the sections.
> >
> > patching file doc/testing.html
> >
> > I added the documentation text for AOT Modules.
> > Skipped renaming id vm_options-1 to vm_options-2 because
> > it does not exist in this file.
> >
> > patching file doc/testing.md
> > Two hunks failed. The first corrects a
> > sentence that is not in 11, skipped.
> > The second adds text about AOT, added.
> >
> > patching file make/RunTests.gmk
> >
> > AOT_MODULES is moved from the SINGLE_KEYWPORDS list
> > to the STRING_KEYWORDS list. This didin't apply due
> > to different context, resolved.
> >
> > Skipped adding a line break because code does not
> > exist in 11.
> >
> > Change in comment for ParseMicroTestSelection skipped,
> > not in 11.
> >
> > Change in comment for ParseSpecialTestSelection
> > skipped, not in 11.
> >
> > Syntactic Change to $1_MICRO_BASIC_OPTIONS skipped, not in 11.
> > Syntactic Change to $1_MICRO_VM_OPTION skipped, not in 11.
> >
> > http://cr.openjdk.java.net/~goetz/wr19/8217634-RunTest_doc-jdk11/01/
> > https://bugs.openjdk.java.net/browse/JDK-8217634
> > http://hg.openjdk.java.net/jdk/jdk/rev/650527b39f00
> >
> > Best regards,
> >   Goetz.


More information about the jdk-updates-dev mailing list