RFR+RFA [11u] 8197398: (zipfs) Files.walkFileTree walk indefinitelly while processing JAR file with "/" as a directory inside.

Aleksey Shipilev shade at redhat.com
Tue Feb 19 13:54:23 UTC 2019


On 2/19/19 2:40 PM, Langer, Christoph wrote:
> Original Fix: http://hg.openjdk.java.net/jdk/jdk/rev/2e4cf4ca074c
> 11u webrev: http://cr.openjdk.java.net/~clanger/webrevs/8197398.jdk11u/

Looks good to me.

So the difference between two patches are these:

*) This one is fine, because there is no such line in 11u at all:

orig: -                e.method = METHOD_STORED;         // STORED for dir
orig: +                e.method = METHOD_STORED;                // STORED for dir

*) ...and this is fixing the typo:

orig: +        // constructor for cenInit() (1) remove tailing '/' (2) pad leading '/'
11u:  +        // constructor for cenInit() (1) remove trailing '/' (2) pad leading '/'

I prefer to backport changes wholesale, along with typos, expecting the potential follow-up commit
that fixes the typos everywhere. Have no strong opinion, through.

Thanks,
-Aleksey



More information about the jdk-updates-dev mailing list