How to run tests before pushing a backport changeset?
Man Cao
manc at google.com
Thu Feb 21 01:33:34 UTC 2019
Thanks, Aleksey! I will run TEST=tier1 for both fastdebug and release
locally then.
jiangli@ will help me push JDK-8218192 to JDK11u and JDK12u soon.
-Man
On Wed, Feb 20, 2019 at 4:09 PM Aleksey Shipilev <shade at redhat.com> wrote:
> On 2/20/19 11:38 PM, Man Cao wrote:
> > I wonder if there is a recommended way to run automated tests before
> pushing a changeset to
> > jdk11u or jdk12u. Is there something like Submit Repo
> > <https://wiki.openjdk.java.net/display/Build/Submit+Repo> for the
> jdk-updates project?
> There is no submit repo for JDK updates.
>
> > I read the links on https://openjdk.java.net/projects/jdk-updates/, but
> couldn't find any
> > description on testing. Does the backporting process require running
> such automated tests before
> > pushing a changeset?
> I think it is maintainer's duty to decide if testing was enough (this is
> why Fix Request requires
> [1] to spell out what testing was done). That said, it seems the more
> tests you run, the more less
> chance backport would be problematic.
>
> In my mind, the bare minimum is to run the regression tests supplied with
> the backport, and also the
> tests for the component you push to. For example, for
> https://bugs.openjdk.java.net/browse/JDK-8218192 that you have on your
> plate, I'd run hotspot_gc:
>
> $ make images run-test TEST=hotspot_gc
>
> Passing tier1 in fastdebug (and release, if you have time) seems to be a
> good sanity test for all
> patches too:
>
> $ make images run-test TEST=tier1
>
> -Aleksey
>
> [1] https://openjdk.java.net/projects/jdk-updates/approval.html
>
>
More information about the jdk-updates-dev
mailing list