RFR+RFA [11u]: 8215175: Inconsistencies in JFR event metadata

[Lindenmaier, Goetz]

Hi,

the changes to the test look good. 
Also the few edits in the rest of the code wrt. the original
make sense.

Best regards,
  Goetz.

> -----Original Message-----
> From: jdk-updates-dev <jdk-updates-dev-bounces at openjdk.java.net> On
> Behalf Of Langer, Christoph
> Sent: Donnerstag, 21. Februar 2019 11:25
> To: Erik Gahlin <erik.gahlin at oracle.com>; hotspot-jfr-dev at openjdk.java.net;
> Aleksey Shipilev <shade at redhat.com>
> Cc: jdk-updates-dev at openjdk.java.net
> Subject: [CAUTION] RE: RFR+RFA [11u]: 8215175: Inconsistencies in JFR event
> metadata
> 
> Hi,
> 
> it turned out that I had to modify the test
> test/jdk/jdk/jfr/api/metadata/annotations/TestFormatMissingValue.java a
> little bit to make it pass. PrettyWriter in jdk/jdk is a bit more modern.
> 
> Please check my updated webrev:
> http://cr.openjdk.java.net/~clanger/webrevs/8215175.jdk11u.1/
> 
> I modified the "assertContains" checks and added a comment.
> 
> After that I think I'm good to push the stack of 8165675, 8213966, 8215175
> and 8215362 to 11u. The nightly testsuite did not show further regressions in
> JFR.
> 
> Thanks
> Christoph
> 
> > -----Original Message-----
> > From: hotspot-jfr-dev <hotspot-jfr-dev-bounces at openjdk.java.net> On
> > Behalf Of Erik Gahlin
> > Sent: Mittwoch, 20. Februar 2019 16:48
> > To: hotspot-jfr-dev at openjdk.java.net
> > Subject: Re: RFR+RFA [11u]: 8215175: Inconsistencies in JFR event metadata
> >
> > Great minds think alike. I did something similar for Oracle JDK.
> >
> > Not exactly the same down to white spaces and line breaks, but it will
> > result in the same output, which is what matters for users and Mission
> > Control.
> >
> > Erik
> >
> > > Hi,
> > >
> > > and another one...
> > >
> > > May I please get reviews for the downport of 8215175 to jdk11u.
> > >
> > > Bug: https://bugs.openjdk.java.net/browse/JDK-8215175
> > > Original Change: http://hg.openjdk.java.net/jdk/jdk/rev/c8b2a408628b
> > > Backport Webrev:
> > http://cr.openjdk.java.net/~clanger/webrevs/8215175.jdk11u/
> > >
> > > The patch did not apply cleanly.
> > >
> > > src/hotspot/share/jfr/metadata/metadata.xml had some fuzz but change
> > is effectively the same as the original one.
> > > src/jdk.jfr/share/classes/jdk/jfr/internal/Utils.java also failed. I copied the
> > changed methods from the code that can be found in jdk/jdk currently.
> > > src/jdk.jfr/share/classes/jdk/jfr/internal/tool/PrettyWriter.java does not
> > exist because of the missing jfr tool. So patch could obviously not be applied
> > to that file.
> > >
> > > I'll run the full test suite before pushing.
> > >
> > > Best regards
> > > Christoph
> > >