[12u] RFR (S): 8228466: Fix build on AIX and with Solaris Studio 12u4 in 12u after HarfBuzz 2.3.1 upgrade

[Baesken, Matthias]

Looks good to me !

Best regards, Matthias



From: Langer, Christoph
Sent: Montag, 22. Juli 2019 08:29
To: jdk-updates-dev at openjdk.java.net<mailto:jdk-updates-dev at openjdk.java.net>; 2d-dev at openjdk.java.net<mailto:2d-dev at openjdk.java.net>; 'rob.mckenna at oracle.com' <rob.mckenna at oracle.com<mailto:rob.mckenna at oracle.com>>
Subject: [12u] RFR (S): 8228466: Fix build on AIX and with Solaris Studio 12u4 in 12u after HarfBuzz 2.3.1 upgrade

Hi,

please review and approve this patch for fixing the AIX and the Solaris/SS12u4 build of JDK12u.

Bug: https://bugs.openjdk.java.net/browse/JDK-8228466
Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8228466.0/

The build issues were only discovered after the final OpenJDK 12.0.2 source was published. Initially I only reported AIX but we also see the build broken on Solaris with the older Sun Studio level 12u4. As per [0], Oracle builds 12u with SS12u6 but we at SAP still used 12u4 and found it working until then. The fix for Solaris seems to be small and harmless, so I request to integrate it as well. The changes prove to work in JDK 11.0.4 [1].

As per prior discussion [2], I request review and approval for pushing this to 12u.

Thanks
Christoph

[0] https://wiki.openjdk.java.net/display/Build/Supported+Build+Platforms
[1] http://hg.openjdk.java.net/jdk-updates/jdk11u/rev/a267d045754a
[2] https://mail.openjdk.java.net/pipermail/jdk-updates-dev/2019-July/001441.html