[PATCH] [8u] Prevent MSDOS8.3 named DLL in built image

[David Holmes]

Hi Ali,

Please take this to jdk8u-dev at openjdk.java.net as 8u is not part of the 
jdk-updates project.

Thanks,
David

On 28/03/2019 10:06 am, Ali Ince wrote:
> Hi All,
> 
> We're working on building JDK8U with VS2017 at AdoptOpenJDK and found out
> that the new vcruntime140.dll is copied to the built image named as
> `vcrunt~1.dll` which is basically because of the extra call to
> `BASIC_FIXUP_PATH` call in `toolchain_windows.m4` file. If the call is
> removed, everything works fine.
> 
> On previous versions of VS, the VC runtime DLL was originally named in 8.3
> style (ex. msvcr100.dll) and BASIC_FIXUP_PATH did not have any affect on
> the file name itself. I've checked with `toolchain_windows.m4` files in
> jdk11u and onwards and also saw that this call doesn't exist.
> 
> I've came up with the following patch which removes this call. I'm not sure
> what's the process about updating the checked-in generated_configure.sh but
> I could also add the patch for that if it's required.
> 
> Let me know if you have any feedback or comments.
> 
> Regards,
> 
> Ali
> 
> ---------------------------------------------
> 
> diff -r e0b7721459ee common/autoconf/toolchain_windows.m4
> --- a/common/autoconf/toolchain_windows.m4    Wed Mar 20 16:32:54 2019 +0000
> +++ b/common/autoconf/toolchain_windows.m4    Thu Mar 28 00:03:10 2019 +0000
> @@ -493,7 +493,6 @@
>       if $ECHO "$MSVC_DLL_FILETYPE" | $GREP "$CORRECT_MSVCR_ARCH" 2>&1 >
> /dev/null; then
>         AC_MSG_RESULT([ok])
>         MSVC_DLL="$POSSIBLE_MSVC_DLL"
> -      BASIC_FIXUP_PATH(MSVC_DLL)
>         AC_MSG_CHECKING([for $DLL_NAME])
>         AC_MSG_RESULT([$MSVC_DLL])
>       else
>