[11u] RFR: 8224474: harfbuzz 2.3.1 code fails to compile with gcc 4.4.7

[Langer, Christoph]

Hi Severin,

looks good to me.

Best regards
Christoph

> -----Original Message-----
> From: jdk-updates-dev <jdk-updates-dev-bounces at openjdk.java.net> On
> Behalf Of Severin Gehwolf
> Sent: Dienstag, 21. Mai 2019 11:34
> To: jdk-updates-dev at openjdk.java.net
> Subject: [11u] RFR: 8224474: harfbuzz 2.3.1 code fails to compile with gcc 4.4.7
> 
> Hi,
> 
> Could I please get a review for this JDK 11u only fix? harfbuzz has
> been upgraded to 2.3.1 between jdk-11.0.4+2 and jdk-11.0.4+3.
> Unfortunately, this breaks the JDK 11u build on CentOS/RHEL 6 with
> system GCC 4.4.7 which the upstream OpenJDK 11u builds machinery uses.
> 
> The fix is rather trivial: Move GCC pragmas outside functions.
> 
> webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-
> 8224474/01/webrev/
> bug: https://bugs.openjdk.java.net/browse/JDK-8224474
> 
> Testing: release/slowdebug builds on Linux x86_64 with gcc 4.4.7.
>          fastdebug build on Linux x86_64 with gcc 8.3.1
> 
> Thoughts?
> 
> Thanks,
> Severin