[11u] RFR: 8224474: harfbuzz 2.3.1 code fails to compile with gcc 4.4.7

[Severin Gehwolf]

Hi Andrew,

On Tue, 2019-05-28 at 23:08 +0100, Andrew John Hughes wrote:
> 
> On 21/05/2019 10:33, Severin Gehwolf wrote:
> > Hi,
> > 
> > Could I please get a review for this JDK 11u only fix? harfbuzz has
> > been upgraded to 2.3.1 between jdk-11.0.4+2 and jdk-11.0.4+3.
> > Unfortunately, this breaks the JDK 11u build on CentOS/RHEL 6 with
> > system GCC 4.4.7 which the upstream OpenJDK 11u builds machinery
> > uses.
> > 
> > The fix is rather trivial: Move GCC pragmas outside functions.
> > 
> > webrev: 
> > http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8224474/01/webrev/
> > bug: https://bugs.openjdk.java.net/browse/JDK-8224474
> > 
> > Testing: release/slowdebug builds on Linux x86_64 with gcc 4.4.7.
> >          fastdebug build on Linux x86_64 with gcc 8.3.1
> > 
> > Thoughts?
> > 
> > Thanks,
> > Severin
> > 
> 
> The HarfBuzz update (JDK-8210782) went to 12 & 13 as well. Should this
> not go there as well, or do we not want to support this older GCC on > 11?

My thinking was it's a JDK 11 only change. Considering JDK-8224087 and
others which push towards newer toolchains for later JDK releases this
change is add odds with that. Only taking JDK-8224087 into account, gcc
4.4.7 has *incomplete* support for -std=c99[1]. I'd be reluctant to
push for it in JDK 13 for this reason.

Thoughts?

Thanks,
Severin

[1] https://gcc.gnu.org/onlinedocs/gcc-4.4.7/gcc/Standards.html