[11u] RFR: 8232879: (zipfs) Writing out data with ZipFileSystem leads to a CRC failure in the generated jar file

Jaikiran Pai jai.forums2013 at gmail.com
Tue Nov 5 04:39:13 UTC 2019


I forgot to include the backport JBS issue link. Here it is
https://bugs.openjdk.java.net/browse/JDK-8233457

-Jaikiran

On 04/11/19 7:55 PM, Jaikiran Pai wrote:
> Can I please get a review and a sponsor for a backport of
> https://bugs.openjdk.java.net/browse/JDK-8232879.
>
> The original fix for that is:
>
>     https://hg.openjdk.java.net/jdk/jdk/rev/9d95d8a8b750
>
> That commit does not apply cleanly on jdk11u-dev due to change in line
> numbers in ZipFileSystem.java and due to usage of Filesystems API, in
> the test, that do not exist in Java 11.
>
> In my backported patch, I have manually applied the diff and also
> updated the test to make it use FileSystems.newFileSystem(...) APIs that
> do exist in Java 11. The usage of these different API for
> FileSystems.newFileSystem(...) shouldn't play a role in what is being
> tested.
>
> The webrev for this backport is hosted at
> https://cr.openjdk.java.net/~jpai/8232879-11u-backport/1/webrev/
>
> I have locally run the test that has been included in this patch and
> also have run the tier1 tests. They have passed (there's an unrelated
> failure in hotspot test in teir1):
>
> ==============================
> Test summary
> ==============================
>    TEST                                              TOTAL  PASS  FAIL
> ERROR  
>>> jtreg:test/hotspot/jtreg:tier1                     1280  1279    
> 1     0 <<
>    jtreg:test/jdk:tier1                               1856  1856    
> 0     0  
>    jtreg:test/langtools:tier1                         3899  3899    
> 0     0  
>    jtreg:test/nashorn:tier1                              0     0    
> 0     0  
>    jtreg:test/jaxp:tier1                                 0     0    
> 0     0  
> ==============================
> TEST FAILURE
>
> -Jaikiran
>
>


More information about the jdk-updates-dev mailing list