[11u]: RFR: JDK-8210403: Refactor java.util.Locale:i18n shell tests to plain java tests

[Langer, Christoph]

Thanks, Matthias.

> -----Original Message-----
> From: Baesken, Matthias <matthias.baesken at sap.com>
> Sent: Freitag, 15. November 2019 14:55
> To: jdk-updates-dev at openjdk.java.net
> Cc: Langer, Christoph <christoph.langer at sap.com>
> Subject: RE: [11u]: RFR: JDK-8210403: Refactor java.util.Locale:i18n shell tests
> to plain java tests
> 
> Hi Christoph, looks good to me .
> 
> Best regards, Matthias
> 
> 
> >
> > Hi,
> >
> > please review the jdk11u backport of  JDK-8210403: Refactor
> > java.util.Locale:i18n shell tests to plain java tests. The backport is requested
> > because it's part of Oracle 11.0.6 as well.
> >
> > Bug: https://bugs.openjdk.java.net/browse/JDK-8210403
> > Original Change: http://hg.openjdk.java.net/jdk/jdk/rev/e4b9475b0508
> > Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8210403.11.0/
> >
> > I had to do the following modifications:
> >
> > 1. test/jdk/java/util/Locale/LocaleProviders.sh was removed. Since the
> files
> > were different between the current 11u version and the jdk/jdk version at
> > the time of removal, I had to hg rm the file and update the webrev.
> >
> > 2. test/jdk/java/util/Locale/LocaleProvidersRun.java had to be modified
> due
> > to the already submitted backport of JDK-8215913 (@Severin
> > Gehwolf<mailto:sgehwolf at redhat.com>):
> >
> > diff -r e850883cae0b test/jdk/java/util/Locale/LocaleProvidersRun.java
> > --- a/test/jdk/java/util/Locale/LocaleProvidersRun.java Wed Oct 17
> 16:37:41
> > 2018 +0800
> > +++ b/test/jdk/java/util/Locale/LocaleProvidersRun.java Thu Nov 07
> 15:56:12
> > 2019 +0100
> > @@ -25,7 +25,7 @@
> >   * @test
> >   * @bug 6336885 7196799 7197573 7198834 8000245 8000615 8001440
> 8008577
> >   *      8010666 8013086 8013233 8013903 8015960 8028771 8054482 8062006
> > - *      8150432
> > + *      8150432 8215913
> >   * @summary tests for "java.locale.providers" system property
> >   * @library /test/lib
> >   * @build LocaleProviders
> > @@ -143,7 +143,7 @@
> >          //testing 8027289 fix, if the platform format default is zh_CN
> >          // this assumes Windows' currency symbol for zh_CN is \u00A5, the
> yen
> >          // (yuan) sign.
> > -        if (!defLang.equals("en") && !defCtry.equals("CN")){
> > +        if (defFmtLang.equals("zh") && defFmtCtry.equals("CN")) {
> >              testRun("JRE,HOST", "bug8027289Test", "FFE5", "", "");
> >              testRun("COMPAT,HOST", "bug8027289Test", "FFE5", "", "");
> >              testRun("HOST", "bug8027289Test", "00A5", "", "");
> >
> > Thanks & Best regards
> > Christoph
> >