[11u] RFR: 8231949: [PPC64, s390]: Make async profiling more reliable

Lindenmaier, Goetz goetz.lindenmaier at sap.com
Thu Nov 21 10:42:28 UTC 2019


Hi Martin, 

thanks for adressing this downport for ppc.
Looks good.

Best regards,
  Goetz. 

> -----Original Message-----
> From: Doerr, Martin <martin.doerr at sap.com>
> Sent: Mittwoch, 20. November 2019 13:02
> To: jdk-updates-dev at openjdk.java.net; Lindenmaier, Goetz
> <goetz.lindenmaier at sap.com>; Stuefe, Thomas <thomas.stuefe at sap.com>
> Subject: [11u] RFR: 8231949: [PPC64, s390]: Make async profiling more reliable
> 
> Hi,
> 
> 
> 
> I'd like to backport "8231949: [PPC64, s390]: Make async profiling more
> reliable" to 11u-dev.
> 
> It applies almost cleanly. I only need to adapt to older signature of
> is_valid_method and Metaspace::contains in thread_linux_ppc.cpp and
> thread_linux_s390.cpp:
> 
> -      if (!Method::is_valid_method(m)) return false;
> 
> -      if (!Metaspace::contains(m->constMethod())) return false;
> 
> +      if (m == NULL || !m->is_valid_method()) return false;
> 
> +      if (!Metaspace::contains((const void*)m->constMethod())) return false;
> 
> 
> 
> While discussing backport of "8221539: [metaspace] Improve
> MetaspaceObj::is_metaspace_obj() and friends" we had decided not to
> backport dependent changes, so I think such signature adaptations are needed
> for jdk11u backports, now.
> 
> 
> 
> Orignial bug:
> 
> https://bugs.openjdk.java.net/browse/JDK-8231949
> 
> 
> 
> Original change:
> 
> https://hg.openjdk.java.net/jdk/jdk/rev/c6cbcc673cd3
> 
> 
> 
> Backport webrev:
> 
> http://cr.openjdk.java.net/~mdoerr/8231949_get_top_frame_for_profiling/11
> u-webrev.00/
> 
> 
> 
> Best regards,
> 
> Martin
> 
> 



More information about the jdk-updates-dev mailing list