Re: [11u] Plan to backport 8184193(JFR Streaming) to jdk11u

[Denghui Dong]

Hi,
  I totally agree with you that we can process the backporting of 8231081 and 8230400 at first.

Thanks,
Denghui Dong
------------------------------------------------------------------
From:Jie Kang <jkang at redhat.com>
Send Time:2019年11月23日(星期六) 00:51
To:Mario Torre <neugens at redhat.com>
Cc:董登辉(卓昂) <denghui.ddh at alibaba-inc.com>; jdk-updates-dev at openjdk.java.net <jdk-updates-dev at openjdk.java.net>
Subject:Re: [11u] Plan to backport 8184193(JFR Streaming) to jdk11u

Jie Kang

On Fri, Nov 22, 2019 at 6:12 AM Mario Torre <neugens at redhat.com> wrote:
>
> Hi Denghui,
>
> I'm generally in favour of this backport, and I would like to see it
> also in 8u, but we need to consider the impact of the API being
> introduced, I fear we will need to go through the CSR again. Also, the
> current spec would be based on an unreleased version of the JDK, so I
> believe we need to wait for JDK14 to become GA anyway.

Hey Denghui,

I'd like to see this as well. Even if the streaming backport
JDK-8184193 has to wait, maybe we can go through the process of
backporting the prerequisites you listed
8231081: TestMetadataRetention fails due to missing symbol id
8230400: Missing constant pool entry for a method in stacktrace

earlier rather than later. They're useful fixes too on their own right
I believe.


Regards,

>
> Cheers,
> Mario
>
> On Fri, Nov 22, 2019 at 11:09 AM Denghui Dong
> <denghui.ddh at alibaba-inc.com> wrote:
> >
> > Hi team,
> >   Currently, the status of JET 349: JFR streaming is integrated.
> > This feature is useful for continuous monitoring, can provide the
> > monitoring system with more detailed information.
> >   jdk-11u is a LTS version, and I think 11u will become the mainstream
> > version in the next few years, so I plan to backport JFR streaming to 11u.
> >
> >   The backport for 8184193 requires several other changes as follows to be backported as
> > well:
> >   - 8225797: OldObjectSample event creates unexpected amount of checkpoint data
> >     RFR for 8225797 has been created by Jaroslav.(https://mail.openjdk.java.net/pipermail/jdk-updates-dev/2019-November/002115.html)
> > so my webrev is based on it.
> >
> >   - 8231081: TestMetadataRetention fails due to missing symbol id
> >     Need to do some manual adjustments, because 8209301 (JVM rename is_anonymous, host_klass to unsafe specific terminology ahead of Unsafe.defineAnonymousClass deprecation) has not been ported to 11u,
> >     and I think it's not necessary.
> >
> >   - 8230400: Missing constant pool entry for a method in stacktrace
> >     Need to do some manual adjustments, because of some different code structures, such as the different name of JfrStump in jfrTypeSetUtils.hpp
> >
> > Bug: https://bugs.openjdk.java.net/browse/JDK-8226511
> > Webrev: http://cr.openjdk.java.net/~ddong/8226511/webrev.00/
> >
> >    What's your comment?
> >
> > Thanks
> > Denghui Dong
>
>
>
> --
> Mario Torre
> Associate Manager, Software Engineering
> Red Hat GmbH <https://www.redhat.com>
> 9704 A60C B4BE A8B8 0F30  9205 5D7E 4952 3F65 7898
>