[11u] RFR: 8215449: Several tests failing when jtreg run with -vmoption:--illegal-access=deny

[Severin Gehwolf]

Hi Christoph,

On Tue, 2019-10-01 at 09:15 +0000, Langer, Christoph wrote:
> Hi Severin,
> 
> I'm wondering if this issue with ReflectionCallerCacheTest also
> exists in jdk/jdk. If so, I suggest it should be fixed there first
> and that fix be backported.

I wasn't able to reproduce the test failure with jdk/jdk. Not sure why.
It only fails on JDK 11u. Thoughts?

Thanks,
Severin

> 
> Best regards
> Christoph
> 
> > -----Original Message-----
> > From: jdk-updates-dev <jdk-updates-dev-bounces at openjdk.java.net> On
> > Behalf Of Severin Gehwolf
> > Sent: Montag, 30. September 2019 17:25
> > To: jdk-updates-dev at openjdk.java.net
> > Subject: [11u] RFR: 8215449: Several tests failing when jtreg run with -
> > vmoption:--illegal-access=deny
> > 
> > Hi,
> > 
> > Please review this Oracle JDK 11 partity patch. Some tests are failing
> > in JDK 11u when VM option --illegal-access=deny is being used. The only
> > test as mentioned in JDK-8215449 which also fails in JDK 11u is
> > RacyHandler.java. Other tests' status is as follows:
> > 
> >  * LocaleProvider.sh (equiv of LocaleProvidersRun.java) doesn't fail
> >    with  --illegal-access=deny
> >  * CanHandleClassFilesTest.java doesn't exist in JDK 11u and isn't
> >    appropriate. JDK-8207954 added that test, which makes no sense for
> >    JDK 11u.
> > 
> > However, I've noticed that other tests are failing in tier1 with --
> > illegal-access=deny. Due to the above and those failures I've done
> > these changes to the original patch:
> > 
> >  * ReflectionCallerCacheTest.java fails with --illegal-access=deny in
> >    OpenJDK 11u. Added 'java.base/java.lang.reflect:+open' to @modules
> >    tag so that the test passes in JDK 11u as well. Requires JDK-8208364
> >  * Drop hunk to LocaleProvidersRun.java as it doesn't apply JDK 11u.
> >  * Omit changes to CanHandleClassFilesTest.java as it doesn't apply to
> >    JDK 11.
> > 
> > Bug: https://bugs.openjdk.java.net/browse/JDK-8215449
> > webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-
> > 8215449/03/webrev/
> > Original changeset: http://hg.openjdk.java.net/jdk/jdk/rev/9dd0a2fdec24
> > 
> > Testing: Relevant tests fail prior with option --illegal-access=deny
> > and pass after.
> > 
> > I'll also backport JDK-8210789 and JDK-8208364. JDK-8210789 applies
> > cleanly and fixes T8152616.java failure with --illegal-access=deny.
> > JDK-8208364 is a pre-requisite of this patch. It also applies cleanly.
> > 
> > Thoughts?
> > 
> > Thanks,
> > Severin