[11u] RFR 8217362: Emergency dump does not work when disk=false is set

[Langer, Christoph]

Hi Denghui,

I’ll look at the backport for JDK-8185525 in due course. It just seems to be a little larger item – so it needs more time ��.

Best regards
Christoph

From: Denghui Dong <denghui.ddh at alibaba-inc.com>
Sent: Dienstag, 1. Oktober 2019 16:02
To: Jie Kang <jkang at redhat.com>; Langer, Christoph <christoph.langer at sap.com>
Cc: jdk-updates-dev <jdk-updates-dev at openjdk.java.net>
Subject: Re: [11u] RFR 8217362: Emergency dump does not work when disk=false is set

Hi Jei kang and Christoph,
  Thank you for your reply. I will check my webrev version, sorry again for duplicate work.
  By the way, Christoph, can you help me to review two patches:
  on for 11u: https://mail.openjdk.java.net/pipermail/jdk-updates-dev/2019-September/001939.html
  on for 8u: https://mail.openjdk.java.net/pipermail/jdk8u-dev/2019-September/010351.html
  Maybe they miss metadata, I will check them later.

Thanks
Denghui Dong
------------------------------------------------------------------
From:Langer, Christoph <christoph.langer at sap.com<mailto:christoph.langer at sap.com>>
Send Time:2019年10月1日(星期二) 16:23
To:Jie Kang <jkang at redhat.com<mailto:jkang at redhat.com>>; 董登辉(卓昂) <denghui.ddh at alibaba-inc.com<mailto:denghui.ddh at alibaba-inc.com>>
Cc:jdk-updates-dev <jdk-updates-dev at openjdk.java.net<mailto:jdk-updates-dev at openjdk.java.net>>
Subject:RE: [11u] RFR 8217362: Emergency dump does not work when disk=false is set

Hi guys,

sorry that I didn't get back to you earlier on this.

I just looked at the webrevs and they are identical and look fine to me. I'll approve the backport request and run it through our testing queue. If everything looks fine, I'll push it tomorrow.

As for the patch metadata: When I import from Jie's webrev, e.g. hg qimport https://cr.openjdk.java.net/~jkang/jdk-8217362/webrev.03/jdk11u-dev.changeset, the patch in my repository has the correct metadata. The imported patch from Denghui's webrev (hg qimport http://cr.openjdk.java.net/~wzhuo/8217362/webrev.00/jdk11u-dev.patch) is missing this. Don't know what's causing this, maybe different webrev versions? The individual file diffs show the information. So I'll go with Jie's version then ��

Best regards
Christoph

> -----Original Message-----
> From: jdk-updates-dev <jdk-updates-dev-bounces at openjdk.java.net<mailto:jdk-updates-dev-bounces at openjdk.java.net>> On
> Behalf Of Jie Kang
> Sent: Donnerstag, 26. September 2019 15:46
> To: Denghui Dong <denghui.ddh at alibaba-inc.com<mailto:denghui.ddh at alibaba-inc.com>>
> Cc: jdk-updates-dev <jdk-updates-dev at openjdk.java.net<mailto:jdk-updates-dev at openjdk.java.net>>
> Subject: Re: [11u] RFR 8217362: Emergency dump does not work when
> disk=false is set
>
> Hey Denghui Dong,
>
> No worries, that is 100% my fault, not yours.
>
> Ah, I didn't see the information inside the patch file:
> http://cr.openjdk.java.net/~wzhuo/8217362/webrev.00/jdk11u-dev.patch
> but I do see it in the individual diffs. I was thinking it might be
> easier to push your patch if the .patch file has the commit data; this
> makes it so $ hg import <patch-file> works smoothly. But, maybe there
> is a better way to grab the patch + info from webrev that I'm not
> familiar with.
>
>
> Regards,
>
>
> On Thu, Sep 26, 2019 at 9:31 AM Denghui Dong
> <denghui.ddh at alibaba-inc.com<mailto:denghui.ddh at alibaba-inc.com>> wrote:
> >
> > Hi Jie Kang,
> >   I'm sorry that I didn't browse the previous mail.
> >   By the way, I think that my webrev has already included the original
> commit information, right ?
> >
> > Thanks,
> > Denghui Dong
> >
> > ------------------------------------------------------------------
> > From:Jie Kang <jkang at redhat.com<mailto:jkang at redhat.com>>
> > Send Time:2019年9月26日(星期四) 20:50
> > To:董登辉(卓昂) <denghui.ddh at alibaba-inc.com<mailto:denghui.ddh at alibaba-inc.com>>
> > Cc:jdk-updates-dev <jdk-updates-dev at openjdk.java.net<mailto:jdk-updates-dev at openjdk.java.net>>
> > Subject:Re: [11u] RFR 8217362: Emergency dump does not work when
> disk=false is set
> >
> > On Thu, Sep 26, 2019 at 3:46 AM 董登辉(卓昂) <denghui.ddh at alibaba-
<mailto:denghui.ddh at alibaba-%0b>> inc.com> wrote:
> > >
> > > Hi all,
> > >   11u has the same problem. Please review this backport, original patch
> doesn't apply cleanly caused by Hunk FAILED
> > > in test/jdk/jdk/jfr/jvm/TestDumpOnCrash.java and
> src/hotspot/share/jfr/recorder/repository/jfrEmergencyDump.cpp
> > >
> > > 11u-webrev:
> > > http://cr.openjdk.java.net/~wzhuo/8217362/webrev.00/
> > >
> > > Original bug:
> > > https://bugs.openjdk.java.net/browse/JDK-8217362
> > > http://hg.openjdk.java.net/jdk/jdk/rev/3cabb47758c9
> > >
> > > Testing: test/jdk/jdk/jfr/jvm/TestDumpOnCrash.java
> >
> >
> > Hi,
> >
> > Looks like I forgot to update the bug and there was a duplicate of
> > work [1] :( That's my fault, sorry for this mistake.
> >
> > In any case, the changes are identical to mine so I think it looks
> > okay, but should include the original commit metadata like author and
> > message. Of course I am not a reviewer so another will need to look.
> >
> > [1] http://mail.openjdk.java.net/pipermail/jdk-updates-dev/2019-
> September/001883.html
> >
> > Regards,
> >
> > >
> > > Thanks,
> > > Denghui Dong