[13u] RFR: 8212970: TZ database in "vanguard" format support

[Andrew John Hughes]

On 26/09/2019 10:45, Ramanand Patil wrote:
> Hi all,
> Please review this backport to JDK13 updates:
> Bug: https://bugs.openjdk.java.net/browse/JDK-8212970
> Webrev: http://cr.openjdk.java.net/~rpatil/8212970/webrev.00/
> Original Changeset: https://hg.openjdk.java.net/jdk/jdk/rev/99d2dd7b84a8
> 
> The patch from jdk14 was not applied cleanly. Here is the change summary:
> 	- All the deletions in test/jdk/sun/util/calendar/zi/tzdata and test/jdk/sun/util/calendar/zi/tzdata_jdk are done manually.
> 	- The original patch(jdk14) had tzdata2019a vanguard format, but since the jdk13u is already patched with tzdata2019b rearguard format, in this patch tzdata files used are from tzdata2019b vanguard format.
> Post this backport, it will be easy to backport future tzdata versions starting tzdata2019c(JDK-8231098).
> 
> All the related tests including JCK are passed.
> 
> 
> Regards,
> Ramanand.
> 

Looks good to me. The only difference between the 13u & 14u patches are
those expected from the tzdata2019b rearguard update to jdk13; rearguard
format Morocco offsets being removed and tzdata2019b data being removed
from the test tree rather than tzdata2019a.

Out of interest, why was the test data removed rather than being
switched to vanguard format versions?

FWIW, tzdata2019c should be a clean backport either way, as the changes
are no different in vanguard or rearguard format. We already backported
it to 8u.

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew