[11u] RFR 8224217: RecordingInfo should use textual representation of path

[Langer, Christoph]

Hi,

thanks for running the review on this. I pushed the fix now after running it through our testing.

Cheers
Christoph

> -----Original Message-----
> From: jdk-updates-dev <jdk-updates-dev-bounces at openjdk.java.net> On
> Behalf Of Severin Gehwolf
> Sent: Dienstag, 8. Oktober 2019 11:56
> To: Denghui Dong <denghui.ddh at alibaba-inc.com>; jdk-updates-
> dev at openjdk.java.net
> Subject: Re: [11u] RFR 8224217: RecordingInfo should use textual
> representation of path
> 
> Hi,
> 
> On Tue, 2019-10-08 at 17:13 +0800, Denghui Dong wrote:
> > Hi all,
> >   Please review this backport, original patch apply cleanly, but will break
> build, it's need to
> > do a little change in DCmdDump.java.
> 
> Next time, please expand *what* the nature of the "little change" in
> DCmdDump.java is. It makes lives of Reviewers easier.
> 
> It looks like the change was originally part of JDK-8220657, but the
> backport to 11, didn't have it, because this patch adds
> getRealPathText() to WriteableUserPath.java which wasn't present when
> JDK-8220657 got backported to JDK 11u.
> 
> > 11u-webrev:
> > http://cr.openjdk.java.net/~ddong/8224217/webrev.00/
> 
> Looks good.
> 
> Only difference to the jdk/jdk patch is the retroactive addition of the
> change done via JDK-8220657 in jdk/jdk.
> 
> I've added a comment on the bug that although it applies cleanly, it
> does not build. Hence a review was needed. Previous comments suggested
> the patch wouldn't need a review.
> 
> Thanks,
> Severin
> 
> > Original bug:
> >  https://bugs.openjdk.java.net/browse/JDK-8224217
> >  http://hg.openjdk.java.net/jdk/jdk/rev/3b22c7e00573
> >
> > Thanks,
> > Denghui Dong