[13u] RFR (S) Backport JDK-8191521: handle long relative path specified in -Xbootclasspath/a on windows

[Langer, Christoph]

Hi Ralf,

your patch looks good to me, seems correctly resolved to jdk13u. I see that you have inlined both, "8231885: Fix/remove malformed assert in os_windows.cpp" and "8231930: Windows build fails after JDK-8191521", which makes sense to me. I've added jdk13u-fix-request labels to these bugs as well.

As you've already put it through SAP's nightly regression testing, I can also confirm that there are no new regressions and the test cases where we saw failures without the patch don't have an error any longer. These are:
vmTestbase/nsk/jvmti/AddToBootstrapClassLoaderSearch/bootclssearch001/TestDescription.java
vmTestbase/nsk/jvmti/AddToBootstrapClassLoaderSearch/bootclssearch002/TestDescription.java
vmTestbase/nsk/jvmti/AddToBootstrapClassLoaderSearch/bootclssearch003/TestDescription.java
vmTestbase/nsk/jvmti/AddToBootstrapClassLoaderSearch/bootclssearch004/TestDescription.java
vmTestbase/nsk/jvmti/AddToBootstrapClassLoaderSearch/bootclssearch007/TestDescription.java
vmTestbase/nsk/jvmti/AddToBootstrapClassLoaderSearch/bootclssearch010/TestDescription.java
vmTestbase/nsk/jvmti/unit/functions/AddToBootstrapClassLoaderSearch/JvmtiTest/TestDescription.java

Thanks
Christoph

> -----Original Message-----
> From: jdk-updates-dev <jdk-updates-dev-bounces at openjdk.java.net> On
> Behalf Of Schmelter, Ralf
> Sent: Donnerstag, 10. Oktober 2019 14:25
> To: jdk-updates-dev at openjdk.java.net
> Subject: [CAUTION] [13u] RFR (S) Backport JDK-8191521: handle long relative
> path specified in -Xbootclasspath/a on windows
> 
> I'd like to backport the change to 13u.
> 
> Original bug:
> https://bugs.openjdk.java.net/browse/JDK-8191521
> 
> Original change:
> https://hg.openjdk.java.net/jdk/jdk/rev/ed5e399d967d
> 
> 11u backport:
> http://cr.openjdk.java.net/~rschmelter/webrevs/8191521/webrev.jdku13.0
> 1/
> 
> The patch had to be modified since it also adjusted the os:: same_files()
> method, which is not present in JDK13.
> Otherwise it applied cleanly.
> 
> Best regards,
> Ralf