[11u] RFR: Backport JDK-8209657: Refactor filemap.hpp to simplify integration with Serviceability Agent

[Jiangli Zhou]

Thank you so much, Christoph! Will wait.

Best regards,
Jiangli

On Thu, Oct 10, 2019 at 3:14 AM Langer, Christoph
<christoph.langer at sap.com> wrote:
>
> Hi Jiangli,
>
> the webrev looks good to me and I ran it together with the other CDS related backports that you requested through our test system. We didn't see regressions.
>
> Please allow some time to consult with Andrew on whether to approve the backports for pushing.
>
> Thanks
> Christoph
>
> > -----Original Message-----
> > From: hotspot-runtime-dev <hotspot-runtime-dev-
> > bounces at openjdk.java.net> On Behalf Of Jiangli Zhou
> > Sent: Donnerstag, 3. Oktober 2019 22:42
> > To: jdk-updates-dev at openjdk.java.net; hotspot-runtime-dev <hotspot-
> > runtime-dev at openjdk.java.net>
> > Subject: [11u] RFR: Backport JDK-8209657: Refactor filemap.hpp to simplify
> > integration with Serviceability Agent
> >
> > Please review the backport of JDK-8209657: Refactor filemap.hpp to
> > simplify integration with Serviceability Agent.
> >
> > webrev: http://cr.openjdk.java.net/~jiangli/backport-8209657/webrev.00/
> >
> > The backport applied 99% cleanly. The only manual part involved was to
> > apply the following diff in filemap.hpp:
> >
> >  311
> >  312   CDSFileMapRegion* space_at(int i) {
> >  313     assert(i >= 0 && i < NUM_CDS_REGIONS, "invalid region");
> >  314     return &_header->_space[i];
> >  315   }
> >  316 };
> >
> > The backport was done with the intention to downporting additional CDS
> > bug fixes and improvements that are depending on this one.
> >
> > Best,
> >
> > Jiangli