[11u] RFR 8229020: Failure on CPUs allowing loads reordering: assert(_tasks[t] == 1) failed: What else?

Zhengyu Gu zgu at redhat.com
Tue Oct 15 12:08:33 UTC 2019


Thanks for reviewing, Paul.

On 10/11/19 5:59 PM, Hohensee, Paul wrote:
> Lgtm. Also, you don't have to request a review if a patch applies cleanly net of file name/location/line number changes. Just note that is the case in your JBS issue comment when you tag the bug with jdk11u-fix-request.

Well, it is not always the case. I was asked to submit code review 
request in similar scenario before. So, I figured just sent code review 
request anyway :-)

-Zhengyu


> 
> Paul
> 
> On 10/11/19, 10:24 AM, "jdk-updates-dev on behalf of Zhengyu Gu" <jdk-updates-dev-bounces at openjdk.java.net on behalf of zgu at redhat.com> wrote:
> 
>      Hi,
>      
>      Please review this one line patch.
>      
>      It removes a paranoid assertion, that may trigger false alarm on weak
>      memory systems.
>      
>      The original patch does not apply cleanly, mainly just due to line shifts.
>      
>      Original patch:http://cr.openjdk.java.net/~jiefu/8229020/webrev.02/
>      Original code review thread:
>      https://mail.openjdk.java.net/pipermail/hotspot-gc-dev/2019-August/026643.html
>      
>      
>      Bug: https://bugs.openjdk.java.net/browse/JDK-8229020
>      Webrev: http://cr.openjdk.java.net/~zgu/JDK-8229020-11u/webrev.00/
>      
>      Thanks,
>      
>      -Zhengyu
>      
>      
> 



More information about the jdk-updates-dev mailing list