[11u] RFR 8185525: Add JFR event for DictionarySizes

[Langer, Christoph]

Hi Denghui,

sorry for the late reply.

I was discussing with Andrew Haley about JFR backports. He encouraged to do a general discussion on the mailing list about the policy regarding non-trivial JFR related backports, which I started just today:
https://mail.openjdk.java.net/pipermail/jdk-updates-dev/2019-October/002053.html
Let’s see if there’s any feedback…

Best regards
Christoph

From: Denghui Dong <denghui.ddh at alibaba-inc.com>
Sent: Dienstag, 22. Oktober 2019 04:09
To: jdk-updates-dev <jdk-updates-dev at openjdk.java.net>; Langer, Christoph <christoph.langer at sap.com>
Subject: Re: [11u] RFR 8185525: Add JFR event for DictionarySizes

Hi Christoph,
  What's the status of this backport ?
  By the way, the previous webrev didn't contain the original commit, so I uploaded a new one in http://cr.openjdk.java.net/~ddong/8185525/webrev/

Thanks,
Denghui Dong
------------------------------------------------------------------
From:Langer, Christoph <christoph.langer at sap.com<mailto:christoph.langer at sap.com>>
Send Time:2019年10月8日(星期二) 22:34
To:董登辉(卓昂) <denghui.ddh at alibaba-inc.com<mailto:denghui.ddh at alibaba-inc.com>>; jdk-updates-dev <jdk-updates-dev at openjdk.java.net<mailto:jdk-updates-dev at openjdk.java.net>>
Subject:RE: [11u] RFR 8185525: Add JFR event for DictionarySizes

Hi Denghui,

this is quite a large JFR enhancement.

Looking at the 11u webrev, I didn't see any obvious issues although there are obviously quite some alterations from the original patch. I'll run it through our regression testing.

However, in any case, we need to carefully decide if and when we allow this patch to jdk11u-dev. I'll get back to you soon.

Best regards
Christoph

> -----Original Message-----
> From: jdk-updates-dev <jdk-updates-dev-bounces at openjdk.java.net<mailto:jdk-updates-dev-bounces at openjdk.java.net>> On
> Behalf Of Denghui Dong
> Sent: Donnerstag, 26. September 2019 17:03
> To: jdk-updates-dev <jdk-updates-dev at openjdk.java.net<mailto:jdk-updates-dev at openjdk.java.net>>
> Subject: [11u] RFR 8185525: Add JFR event for DictionarySizes
>
> Hi all,
>   Please review this backport, original patch doesn't apply cleanly, because
> SymbolTable has made some changes in upstream (I think it's not necessary
> to backport those changes)
> and class ClassLoaderDataGraph is located in different files.
> 11u-webrev:
> http://cr.openjdk.java.net/~wzhuo/8185525/webrev.00/
> Original bug:
> https://bugs.openjdk.java.net/browse/JDK-8185525
>  http://hg.openjdk.java.net/jdk/jdk/rev/865ec913f916
> Testing: test/jdk/jdk/jfr/event/runtime/TestTableStatisticsEvent.java
>
> Thanks,
> Denghui Dong