[11u] RFR: 8213448 [TESTBUG] enhance jfr/jvm/TestDumpOnCrash
Langer, Christoph
christoph.langer at sap.com
Sun Sep 1 06:30:52 UTC 2019
Hi Jie,
I approved the 11u fix. I assume you'll be happy if I also push the change for you as you aren't a committer, correct?
Best regards
Christoph
> -----Original Message-----
> From: Langer, Christoph
> Sent: Freitag, 30. August 2019 14:09
> To: Jie Kang <jkang at redhat.com>; jdk-updates-dev at openjdk.java.net
> Subject: RE: [11u] RFR: 8213448 [TESTBUG] enhance
> jfr/jvm/TestDumpOnCrash
>
> Hi Jie,
>
> this looks good to me.
>
> Best regards
> Christoph
>
> > -----Original Message-----
> > From: jdk-updates-dev <jdk-updates-dev-bounces at openjdk.java.net> On
> > Behalf Of Jie Kang
> > Sent: Mittwoch, 28. August 2019 16:59
> > To: jdk-updates-dev at openjdk.java.net
> > Subject: [11u] RFR: 8213448 [TESTBUG] enhance jfr/jvm/TestDumpOnCrash
> >
> > Hi all,
> >
> > Please review this test-only backport of 8213448 to OpenJDK jdk11u-dev
> > so as to get a significantly cleaner backport for JDK-8217362 [1]. The
> > fix did not apply cleanly as a one-line removal to the file is missing
> > from JDK-8209856 [2]. My process was to make this one-line removal,
> > apply the patch, and then revert the one line removal. I have run tier
> > one tests and jfr specific tests successfully. Please let me know how
> > it looks and if it is appropriate to backport to 11.
> >
> > Webrev: http://cr.openjdk.java.net/~jkang/jdk-8213448/webrev.00/
> > Original Changeset: http://hg.openjdk.java.net/jdk/jdk/rev/f0af7fd0c9ca
> > Bug: https://bugs.openjdk.java.net/browse/JDK-8213448
> >
> > [1]
> > Would allow a cleaner backport of:
> > http://hg.openjdk.java.net/jdk/jdk/rev/3cabb47758c9#l5.1
> > https://bugs.openjdk.java.net/browse/JDK-8217362
> >
> > [2]
> > The missing one-line removal:
> > http://hg.openjdk.java.net/jdk/jdk/rev/d7fc38d3fc8d#l19.7
> > https://bugs.openjdk.java.net/browse/JDK-8209856
More information about the jdk-updates-dev
mailing list