[11u] RFR: 8213448 [TESTBUG] enhance jfr/jvm/TestDumpOnCrash

[Langer, Christoph]

Hi Jie,

great. I added your new patch to our nightly test queue. I'll probably push it tomorrow once the test results show green.

Thanks & Best regards
Christoph

> -----Original Message-----
> From: Jie Kang <jkang at redhat.com>
> Sent: Dienstag, 3. September 2019 15:49
> To: Langer, Christoph <christoph.langer at sap.com>
> Cc: jdk-updates-dev at openjdk.java.net
> Subject: Re: [11u] RFR: 8213448 [TESTBUG] enhance
> jfr/jvm/TestDumpOnCrash
> 
> On Sun, Sep 1, 2019 at 2:31 AM Langer, Christoph
> <christoph.langer at sap.com> wrote:
> >
> > Hi Jie,
> >
> > I approved the 11u fix. I assume you'll be happy if I also push the change for
> you as you aren't a committer, correct?
> 
> Hi Christoph,
> 
> Yes that would be appreciated. I have also added an updated webrev
> below that maintains the proper commit message and author from
> jdk/jdk. I have compared the raw file to my previous webrev to be the
> same, as well as to the original commit to only differ with the single
> line ("-XX:-TransmitErrorReport") described previously.
> 
> Updated webrev:
> http://cr.openjdk.java.net/~jkang/jdk-8213448/webrev.01/
> 
> I will make sure to do this from now on; thank you!
> 
> 
> Regards,
> 
> >
> > Best regards
> > Christoph
> >
> > > -----Original Message-----
> > > From: Langer, Christoph
> > > Sent: Freitag, 30. August 2019 14:09
> > > To: Jie Kang <jkang at redhat.com>; jdk-updates-dev at openjdk.java.net
> > > Subject: RE: [11u] RFR: 8213448 [TESTBUG] enhance
> > > jfr/jvm/TestDumpOnCrash
> > >
> > > Hi Jie,
> > >
> > > this looks good to me.
> > >
> > > Best regards
> > > Christoph
> > >
> > > > -----Original Message-----
> > > > From: jdk-updates-dev <jdk-updates-dev-bounces at openjdk.java.net>
> On
> > > > Behalf Of Jie Kang
> > > > Sent: Mittwoch, 28. August 2019 16:59
> > > > To: jdk-updates-dev at openjdk.java.net
> > > > Subject: [11u] RFR: 8213448 [TESTBUG] enhance
> jfr/jvm/TestDumpOnCrash
> > > >
> > > > Hi all,
> > > >
> > > > Please review this test-only backport of 8213448 to OpenJDK jdk11u-
> dev
> > > > so as to get a significantly cleaner backport for JDK-8217362 [1]. The
> > > > fix did not apply cleanly as a one-line removal to the file is missing
> > > > from JDK-8209856 [2]. My process was to make this one-line removal,
> > > > apply the patch, and then revert the one line removal. I have run tier
> > > > one tests and jfr specific tests successfully. Please let me know how
> > > > it looks and if it is appropriate to backport to 11.
> > > >
> > > > Webrev: http://cr.openjdk.java.net/~jkang/jdk-8213448/webrev.00/
> > > > Original Changeset:
> http://hg.openjdk.java.net/jdk/jdk/rev/f0af7fd0c9ca
> > > > Bug: https://bugs.openjdk.java.net/browse/JDK-8213448
> > > >
> > > > [1]
> > > > Would allow a cleaner backport of:
> > > > http://hg.openjdk.java.net/jdk/jdk/rev/3cabb47758c9#l5.1
> > > > https://bugs.openjdk.java.net/browse/JDK-8217362
> > > >
> > > > [2]
> > > > The missing one-line removal:
> > > > http://hg.openjdk.java.net/jdk/jdk/rev/d7fc38d3fc8d#l19.7
> > > > https://bugs.openjdk.java.net/browse/JDK-8209856