[11u] RFR 8215032: Support Kerberos cross-realm referrals (RFC 6806)

[Langer, Christoph]

Hi Martin,

thanks for creating the CSR. Although it seems there's not much benefit of it in this particular case, I think CSR is a review type that should be done for update releases. Maybe there are inappropriate interface changes which neither the engineer that does the backport nor a maintainer of an  update release can oversee. I would hope such things get caught there.

Best regards
Christoph

> -----Original Message-----
> From: Martin Balao <mbalao at redhat.com>
> Sent: Dienstag, 3. September 2019 18:52
> To: Langer, Christoph <christoph.langer at sap.com>; jdk-updates-
> dev at openjdk.java.net
> Subject: Re: [11u] RFR 8215032: Support Kerberos cross-realm referrals (RFC
> 6806)
> 
> Hi Christoph,
> 
> Thanks for having a look at this one.
> 
> I'm still not sure of the value of a new CSR when there are no
> version-specific changes, as in this case. My proposal for these cases
> was for the maintainer to consider the original CSR output and decide
> whether the backport is approved or not.
> 
> Anyways, here it is the new CSR (a copy & paste of the original, with a
> few references to JDK-11 review thread and webrev):
> https://bugs.openjdk.java.net/browse/JDK-8230496
> 
> I'll rebase the proposed changeset to 8224589.
> 
> Kind regards,
> Martin.-
> 
> 
> On 8/30/19 8:45 AM, Langer, Christoph wrote:
> > Hi Martin,
> >
> > review-wise this looks ok. Seems most part of the change applies cleanly,
> net copyright.
> >
> > As for SecurityProperties.java, you should await the landing of JDK-8224589
> in jdk11u-dev. Then you won't need to do anything for it.
> >
> > Process-wise, you'll need to go through CSR review with this. Please create
> a backport item for this bug with fix version 11-pool and then create a CSR
> from that backport. You can probably largely copy and paste the content of
> the original CSR. Once this is reviewed, we'll approve the fix (again) for 11u.
> The CSR is needed to make sure no inappropriate changes in behavior get
> backported - though I don't think that's the case with this.
> >
> > Thanks
> > Christoph
> >