[11u]: RFR JDK-8227368: EnumSet.class serialization broken in JDK 9+

Stuart Marks stuart.marks at oracle.com
Mon Sep 9 23:46:12 UTC 2019



On 9/5/19 11:28 PM, Langer, Christoph wrote:
>> Hi, thanks for testing. Any results yet?
> 
> I'd say it looks great �� No issues spotted...

Great, thanks.

>> Thanks also for reviewing the CSR. It's approved now.
>>
>> Regarding the metadata for the patch, my inclination is for me to be the author
>> of the patch and to list Peter among the reviewers. Of course while Peter
>> deserves the credit for finding the problem in the first place and for fixing it
>> in JDK 13, this "backport" is significantly different from the original bugfix.
>> More importantly, I think I should be listed as the author as an indication of
>> responsibility for it. That is, if something were to go wrong with this patch,
>> I'd be responsible for fixing it. Does that make sense?
> 
> Sure, perfect.
> 
>> I can push the change myself. Is this still ok to go into 11.0.5?
> 
> I would like to see this change hit the same OpenJDK release as the Oracle release. For Oracle I can see a backport item for 11.0.6-oracle (JDK-8228350). Do you intend to promote it to 11.0.5 as well?

OK, targeting both 11.0.6-openjdk and 11.0.6-oracle seems reasonable. As you 
noted, it looks like a backport is pending for 11.0.6-oracle. An email from 
Goetz L a couple weeks ago [1] says that changes pushed to [OpenJDK] jdk11u-dev 
will end up in 11.0.6. So it seems that I could just push this to jdk11u-dev, 
and then work internally to move ahead with the 11.0.6-oracle backport, and this 
will end up with the desired outcome.

Is that right?

Just making extra sure because I not too familiar with working on the OpenJDK 
update releases.

Thanks.

s'marks




[1] https://mail.openjdk.java.net/pipermail/jdk-updates-dev/2019-August/001789.html




More information about the jdk-updates-dev mailing list