[RFR 11u] 8230923: SunJSSE is not properly initialized in FIPS mode from a configuration file

[Andrew John Hughes]

On 12/09/2019 17:38, Martin Balao wrote:
> Hi,
> 
> I'd like to propose a fix for 8230923 [1].
> 
> Webrev.00:
> 
>  * http://cr.openjdk.java.net/~mbalao/webrevs/8230923/8230923.webrev.00/
> 
> Can I have a review?
> 
> Thanks,
> Martin.-
> 
> --
> [1] - https://bugs.openjdk.java.net/browse/JDK-8230923
> 

This appears to be a regression caused by:

https://bugs.openjdk.java.net/browse/JDK-7191662
https://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/2f69eb7d4b90

Given that the relevant erased section there is:

-                    if (hasArgument() == false) {

-                        obj = provClass.newInstance();

-                    } else {

-                        Constructor<?> cons =
provClass.getConstructor(CL_STRING);

-                        obj = cons.newInstance(argument);

-                    }

your fix seems right to me and I can confirm the test fails on current
jdk11 and passes with this patch.

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew