Re: [11u] RFR 8217362: Emergency dump does not work when disk=false is set

[Denghui Dong]

Hi Jie Kang,
  I'm sorry that I didn't browse the previous mail.
  By the way, I think that my webrev has already included the original commit information, right ?

Thanks,
Denghui Dong
------------------------------------------------------------------
From:Jie Kang <jkang at redhat.com>
Send Time:2019年9月26日(星期四) 20:50
To:董登辉(卓昂) <denghui.ddh at alibaba-inc.com>
Cc:jdk-updates-dev <jdk-updates-dev at openjdk.java.net>
Subject:Re: [11u] RFR 8217362: Emergency dump does not work when disk=false is set

On Thu, Sep 26, 2019 at 3:46 AM 董登辉(卓昂) <denghui.ddh at alibaba-inc.com> wrote:
>
> Hi all,
>   11u has the same problem. Please review this backport, original patch doesn't apply cleanly caused by Hunk FAILED
> in test/jdk/jdk/jfr/jvm/TestDumpOnCrash.java and src/hotspot/share/jfr/recorder/repository/jfrEmergencyDump.cpp
>
> 11u-webrev:
> http://cr.openjdk.java.net/~wzhuo/8217362/webrev.00/
>
> Original bug:
> https://bugs.openjdk.java.net/browse/JDK-8217362
> http://hg.openjdk.java.net/jdk/jdk/rev/3cabb47758c9
>
> Testing: test/jdk/jdk/jfr/jvm/TestDumpOnCrash.java


Hi,

Looks like I forgot to update the bug and there was a duplicate of
work [1] :( That's my fault, sorry for this mistake.

In any case, the changes are identical to mine so I think it looks
okay, but should include the original commit metadata like author and
message. Of course I am not a reviewer so another will need to look.

[1] http://mail.openjdk.java.net/pipermail/jdk-updates-dev/2019-September/001883.html

Regards,

>
> Thanks,
> Denghui Dong