[11u] RFR: 8232080: jlink plugins for vendor information and command-line options

[Langer, Christoph]

Hi Severin,

thanks also for this review. I'm pushing this as well and I've requested JDK-8239557 for approval.

Cheers
Christoph

> -----Original Message-----
> From: Severin Gehwolf <sgehwolf at redhat.com>
> Sent: Freitag, 10. April 2020 16:03
> To: Langer, Christoph <christoph.langer at sap.com>; jdk-updates-
> dev at openjdk.java.net
> Subject: Re: [11u] RFR: 8232080: jlink plugins for vendor information and
> command-line options
> 
> Hi Christoph,
> 
> On Sun, 2020-04-05 at 14:18 +0000, Langer, Christoph wrote:
> > Hi,
> >
> > now, please review the backport of JDK-8232080: jlink plugins for
> > vendor information and command-line options. It's part of Oracle's
> > 11.0.7 and contains valuable functionality for downstream vendors and
> > jlinkers.
> >
> > Bug: https://bugs.openjdk.java.net/browse/JDK-8232080
> > Original change: https://hg.openjdk.java.net/jdk/jdk/rev/6c255334120d
> > Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8232080.11u.0/
> 
> This looks good to me. Nice work!
> 
> > Its prerequisite is the backport of 8242154: Backport parts of JDK-
> > 4947890 to OpenJDK 11u which I posted yesterday [0].
> >
> > With that change in place, I had to do the following:
> > - resolve src/hotspot/share/classfile/classLoader.cpp
> > - ignore src/hotspot/share/runtime/vmStructs.cpp, which does not apply
> > - resolve src/hotspot/share/utilities/vmError.cpp
> > - resolve src/java.base/share/classes/java/lang/VersionProps.java
> > - ignore
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/VM.java
> which does not apply
> 
> Right. JDK-8217845 isn't in OpenJDK 11u. OK.
> 
> > I furthermore changed the version information of ASM to ASM6 (instead
> > of ASM7) since that's the level in JDK11. But functionality-wise
> > that's no problem. Everything used is part of ASM6 as well.
> >
> > With this patch I plan to push backports of JDK-8233137, JDK-8233291
> > and JDK-8234696 as they contain follow-up fixes.
> 
> Please also consider JDK-8239557 in this batch.
> 
> Thanks,
> Severin
> 
> > Thanks
> > Christoph
> >
> > [0] https://mail.openjdk.java.net/pipermail/jdk-updates-dev/2020-
> April/002955.html
> >