[11u] RFR: 8236211: [Graal] compiler/graalunit/GraphTest.java is skipped in all testing
Langer, Christoph
christoph.langer at sap.com
Mon Apr 27 18:43:41 UTC 2020
Hi Chris,
> Thanks! Pushed.
seems like you're not quite familiar with the jdk-updates process yet
I can recommend 2 nice Wiki pages for reading:
https://wiki.openjdk.java.net/display/JDKUpdates/JDK11u
https://wiki.openjdk.java.net/display/JDKUpdates/How+to+contribute+a+fix
TL;DR: Before you are allowed to push, a maintainer needs to label the bug with "jdk11u-fix-yes".
OK, in your case, it's a simple test fix that got a review, so no objections, I've labeled it accordingly. Please take care next time...
Cheers
Christoph
>
> > On Apr 27, 2020, at 5:39 PM, Hohensee, Paul <hohensee at amazon.com>
> wrote:
> >
> > Lgtm.
> >
> > Paul
> >
> > On 4/24/20, 11:17 AM, "jdk-updates-dev on behalf of Christian Thalinger"
> <jdk-updates-dev-bounces at openjdk.java.net on behalf of
> cthalinger at twitter.com> wrote:
> >
> > https://bugs.openjdk.java.net/browse/JDK-8236211
> > https://hg.openjdk.java.net/jdk/jdk/rev/9a36b6a6d502
> > http://cr.openjdk.java.net/~twisti/8236211/webrev/index.html
> >
> > The patches doesn’t apply cleanly but only because of copyright year
> differences and other small things:
> >
> > $ hg import --partial 8236211.patch
> > applying 8236211.patch
> > patching file test/hotspot/jtreg/compiler/graalunit/GraphTest.java
> > Hunk #1 FAILED at 0
> > Hunk #2 FAILED at 24
> > 2 out of 2 hunks FAILED -- saving rejects to file
> test/hotspot/jtreg/compiler/graalunit/GraphTest.java.rej
> > patching file test/hotspot/jtreg/compiler/graalunit/NodesTest.java
> > Hunk #1 FAILED at 0
> > Hunk #2 FAILED at 24
> > 2 out of 2 hunks FAILED -- saving rejects to file
> test/hotspot/jtreg/compiler/graalunit/NodesTest.java.rej
> > patching file test/hotspot/jtreg/compiler/graalunit/TestPackages.txt
> > Hunk #1 FAILED at 9
> > Hunk #2 succeeded at 15 with fuzz 2 (offset -5 lines).
> > 1 out of 2 hunks FAILED -- saving rejects to file
> test/hotspot/jtreg/compiler/graalunit/TestPackages.txt.rej
> > patching file
> test/hotspot/jtreg/compiler/graalunit/common/GraalUnitTestLauncher.java
> > Hunk #1 FAILED at 0
> > 1 out of 2 hunks FAILED -- saving rejects to file
> test/hotspot/jtreg/compiler/graalunit/common/GraalUnitTestLauncher.java.
> rej
> > patch applied partially
> > (fix the .rej files and run `hg commit --amend`)
> >
> >
More information about the jdk-updates-dev
mailing list