[11u] Backport 8241638: launcher time metrics always report 1 on Linux when _JAVA_LAUNCHER_DEBUG set(Internet mail)
linzang(臧琳)
linzang at tencent.com
Thu Apr 30 02:23:31 UTC 2020
Hi Christoph,
Thanks for your guidance, I will follow them next time.
BRs,
Lin
From: "Langer, Christoph" <christoph.langer at sap.com>
Date: Thursday, April 30, 2020 at 6:28 AM
To: "linzang(臧琳)" <linzang at tencent.com>, "jdk-updates-dev at openjdk.java.net" <jdk-updates-dev at openjdk.java.net>
Cc: "Hohensee, Paul" <hohensee at amazon.com>
Subject: RE: [11u] Backport 8241638: launcher time metrics always report 1 on Linux when _JAVA_LAUNCHER_DEBUG set(Internet mail)
Hi Lin,
looks good to me, too.
As written in the bug, I’ll sponsor this after one additional round in SAP’s regression testing..
I’ve got one hint: For future backports you could export the original fix with hg export –git … and then qimport the resulting file into jdk11u-dev and make your adaptions via hg qrefresh. This will keep the patch metadata (patch comment and Reviewed-by attributions) intact and will ease sponsoring from a webrev.
Thanks & Best regards
Christoph
From: linzang(臧琳) <linzang at tencent.com>
Sent: Dienstag, 28. April 2020 18:33
To: Langer, Christoph <christoph.langer at sap.com>; jdk-updates-dev at openjdk.java.net
Subject: Re: [11u] Backport 8241638: launcher time metrics always report 1 on Linux when _JAVA_LAUNCHER_DEBUG set
Hi Christoph,
Here is the updated patches:
Issue: https://bugs.openjdk.java.net/browse/JDK-8241638
Webrev: http://cr.openjdk.java.net/~lzang/8241638/11u/webrev11_01/
issue: https://bugs.openjdk.java.net/browse/JDK-8243539
webrev: http://cr.openjdk.java.net/~lzang/8243539/webrev11_01/
would you like to help review? Thanks!
BRs,
Lin
From: "linzang(臧琳)" <linzang at tencent.com<mailto:linzang at tencent.com>>
Date: Tuesday, April 28, 2020 at 11:20 PM
To: "Langer, Christoph" <christoph.langer at sap.com<mailto:christoph.langer at sap.com>>, "jdk-updates-dev at openjdk.java.net<mailto:jdk-updates-dev at openjdk.java.net>" <jdk-updates-dev at openjdk.java.net<mailto:jdk-updates-dev at openjdk.java.net>>
Subject: Re: [11u] Backport 8241638: launcher time metrics always report 1 on Linux when _JAVA_LAUNCHER_DEBUG set
Hi Christoph,
After rethink of it, I think making two separate patches for backport may be more reasonable, which makes the commit log clear.
I will made the patches ASAP and then ask your help to reivew,Thanks!
BRs,
Lin
From: "linzang(臧琳)" <linzang at tencent.com<mailto:linzang at tencent.com>>
Date: Tuesday, April 28, 2020 at 4:05 PM
To: "Langer, Christoph" <christoph.langer at sap.com<mailto:christoph.langer at sap.com>>, "jdk-updates-dev at openjdk.java.net<mailto:jdk-updates-dev at openjdk.java.net>" <jdk-updates-dev at openjdk.java.net<mailto:jdk-updates-dev at openjdk.java.net>>
Subject: [11u] Backport 8241638: launcher time metrics always report 1 on Linux when _JAVA_LAUNCHER_DEBUG set
Hi All,
May I have your help to review this tiny patch, it is a clean backport of 8241638.
And this patch also include the backport of 8243539, which is the fix of the copyright update issue of 8241638.
Webrev: http://cr.openjdk.java.net/~lzang/8241638/11u/webrev11/
Issues: https://bugs.openjdk.java.net/browse/JDK-8241638
https://bugs.openjdk.java.net/browse/JDK-8243539
Thanks!
BRs,
Lin
More information about the jdk-updates-dev
mailing list