[11u] RFR(M) 8245981: Upgrade to jQuery 3.5.1

[Langer, Christoph]

OK, looks good to me now. I'll approve it.

Cheers
Christoph

> -----Original Message-----
> From: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>
> Sent: Montag, 31. August 2020 12:35
> To: Langer, Christoph <christoph.langer at sap.com>
> Cc: jdk-updates-dev at openjdk.java.net
> Subject: RE: [11u] RFR(M) 8245981: Upgrade to jQuery 3.5.1
> 
> I tried to remove it before, but somehow this got lost ...
> http://cr.openjdk.java.net/~goetz/wr20/8245981-jquery_3.5.1-jdk11/03/
> 
> In any case, I'll run the patch through our testing once more.
> 
> Best regards,
>   Goetz.
> 
> -----Original Message-----
> From: Langer, Christoph <christoph.langer at sap.com>
> Sent: Montag, 31. August 2020 12:02
> To: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>
> Cc: jdk-updates-dev at openjdk.java.net
> Subject: RE: [11u] RFR(M) 8245981: Upgrade to jQuery 3.5.1
> 
> Hi Goetz,
> 
> looks good. You should also remove src/jdk.javadoc/share/legal/jquery-
> migrate.md as per http://hg.openjdk.java.net/jdk/jdk/rev/4f1f939d8f5d.
> 
> Best regards
> Christoph
> 
> > -----Original Message-----
> > From: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>
> > Sent: Montag, 31. August 2020 11:35
> > To: Langer, Christoph <christoph.langer at sap.com>
> > Cc: jdk-updates-dev at openjdk.java.net
> > Subject: RE: [11u] RFR(M) 8245981: Upgrade to jQuery 3.5.1
> >
> > Hi,
> >
> > Yes, removing that file is a good idea. New webrev:
> > http://cr.openjdk.java.net/~goetz/wr20/8245981-jquery_3.5.1-jdk11/02/
> >
> > Best regards,
> >   Goetz.
> >
> > -----Original Message-----
> > From: Langer, Christoph <christoph.langer at sap.com>
> > Sent: Montag, 31. August 2020 10:05
> > To: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>
> > Cc: jdk-updates-dev at openjdk.java.net
> > Subject: RE: [11u] RFR(M) 8245981: Upgrade to jQuery 3.5.1
> >
> > Hi Goetz,
> >
> > generally, your approach and patch look fine to me.
> >
> > However, looking at the intermediate step of migrating from 3.3.1 to 3.4.1
> > which was missed out in OpenJDK11 so far
> > (https://bugs.openjdk.java.net/browse/JDK-8222548), I can see that
> jquery-
> > migrate-3.0.1.js was removed there. I think this part should be
> incorporated
> > into this backport as well.
> >
> > Best regards
> > Christoph
> >
> > > -----Original Message-----
> > > From: jdk-updates-dev <jdk-updates-dev-retn at openjdk.java.net> On
> > > Behalf Of Lindenmaier, Goetz
> > > Sent: Samstag, 29. August 2020 11:07
> > > To: jdk-updates-dev at openjdk.java.net
> > > Subject: [CAUTION] [11u] RFR(M) 8245981: Upgrade to jQuery 3.5.1
> > >
> > > Hi,
> > >
> > > please review this downport for parity with Oracle.
> > > http://cr.openjdk.java.net/~goetz/wr20/8245981-jquery_3.5.1-jdk11/01
> > >
> > > In 11, the update from jquery 3.3.1 to 3.4.1 is missing.
> > > Therefore the change does not apply.
> > > Also, a change renaming the /jquery/ directory is missing
> > > in 11, another deleting some useless files and finally one
> > > minifying the script.
> > >
> > > So I basically crafted the change anew:
> > >  * I renamed jquery-3.3.1.js to jquery-3.5.1.js and replaced
> > >    it by the new file.
> > >  * I updated all the files referencing the file with the version in the name.
> > >  * In addition, I updated APITest.java because else these test are failing.
> > >  * I replaced jquery.js by the new file (jquery.js was deleted in jdk/jdk).
> > >  * I omitted the minified version as 8236823 is not in 11.
> > >
> > > Our tests are all green.
> > >
> > > Best regards,
> > >   Goetz.
> > >
> > > Here all the related changes:
> > >
> > > https://bugs.openjdk.java.net/browse/JDK-8204666 : javadoc should be
> > > updated to use jQuery 3.3.1
> > > https://bugs.openjdk.java.net/browse/JDK-8221644 : jquery directory
> > > should be renamed
> > > https://bugs.openjdk.java.net/browse/JDK-8222548 : Upgrading JDK 13
> > with
> > > the latest available jQuery 3.4.1
> > > https://bugs.openjdk.java.net/browse/JDK-8238167 : Remove stray files
> > > from jdk.javadoc
> > > https://bugs.openjdk.java.net/browse/JDK-8236823 : Ensure that API
> > > documentation uses minified libraries
> > > https://bugs.openjdk.java.net/browse/JDK-8245981 : Upgrade to jQuery
> > > 3.5.1