[11u] RFR:8214230: Classes generated by SystemModulesPlugin.java are not reproducable

[Doerr, Martin]

Hi,

we have seen intermittent failures in the new test which was introduced by this change:
test result: Failed. Execution failed: `main' threw exception: java.lang.RuntimeException: assertEquals: expected -1 to equal 52944
(or other numbers at the end)

Note that there's a follow-up change:
https://bugs.openjdk.java.net/browse/JDK-8232864

Best regards,
Martin


> -----Original Message-----
> From: jdk-updates-dev <jdk-updates-dev-retn at openjdk.java.net> On
> Behalf Of Hohensee, Paul
> Sent: Montag, 14. Dezember 2020 18:30
> To: hedongbo <hedongbo at huawei.com>; jdk-updates-
> dev at openjdk.java.net
> Subject: RE: [11u] RFR:8214230: Classes generated by
> SystemModulesPlugin.java are not reproducable
> 
> Lgtm.
> 
> Thanks,
> Paul
> 
> -----Original Message-----
> From: jdk-updates-dev <jdk-updates-dev-retn at openjdk.java.net> on
> behalf of hedongbo <hedongbo at huawei.com>
> Date: Sunday, December 13, 2020 at 5:38 PM
> To: "jdk-updates-dev at openjdk.java.net" <jdk-updates-
> dev at openjdk.java.net>
> Subject: [11u] RFR:8214230: Classes generated by SystemModulesPlugin.java
> are not reproducable
> 
> Hi,
> 
> 
> 
> Please review the backport of JDK-8214230 to 11u:
> 
> 
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8214230
> 
> 
> 
> Original commit: http://hg.openjdk.java.net/jdk/jdk/rev/abccada595dd
> 
> 
> 
> 11u webrev: http://cr.openjdk.java.net/~dongbohe/8214230/webrev.00/
> 
> 
> 
> Patch applies cleanly to11u, but I added a static method `mismatch(Path,
> Path)` to the test file because it only exists in jdk12[1]. Moreover, I also
> modified the copyright year.
> 
> 
> Tested with tier1, tier2. No regression in tests.
> 
> 
> 
> 
> 
> [1] https://bugs.openjdk.java.net/browse/JDK-8202302
> 
> 
> Thanks,
> dongbohe